New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637299 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

DevTools Security Panel doesn't offer a way to inspect the site while the intersitial is up

Project Member Reported by rsleevi@chromium.org, Aug 12 2016

Issue description

Version: Version 54.0.2827.0 canary (64-bit)
OS: 10.11.6

What steps will reproduce the problem?
(1) Load empty browser
(2) Open https://www.united.com
(3) See Certificate Error.
(4) Open Security Panel in Dev Tools
(5) See it has no origins, so it says reload
(6) Click Reload
(7) www.google.com loads (previous page prior to united)
(8) See that's not what you wanted, type in https://www.united.com

What is the expected output?
DevTools would show the connection to www.united.com

What do you see instead?
DevTools does not show the connection to www.united.com

Please use labels and text to provide additional information.

 
Screen Shot 2016-08-12 at 8.38.56 AM.png
472 KB View Download
Cc: -lgar...@chromium.org
Owner: lgar...@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by est...@chromium.org, Nov 29 2016

Owner: est...@chromium.org
Status: Started (was: Assigned)
I'm working on a partial fix for this (hiding the prompt to reload, which is a hack that we already do when you navigate to an interstitial when the security panel is open, because reloading on an interstitial usually doesn't give you any more useful information).

I split out  issue 669316  (the interstitial disappears when you refresh with devtools open and doesn't come back) as a separate bug.

Comment 3 by est...@chromium.org, Nov 29 2016

Cc: lgar...@chromium.org
Labels: -OS-Mac Team-Security-UX OS-All
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8d89eaf15d68b685f1d1e0503a2057df1082a75

commit f8d89eaf15d68b685f1d1e0503a2057df1082a75
Author: estark <estark@chromium.org>
Date: Tue Nov 29 04:16:19 2016

Do not prompt for reload when security panel is opened on an interstitial

Because interstitials are not real navigations, the security panel
sidebar doesn't work properly for an interstitial, and also doesn't
provide that much more useful information than what's shown in the
Overview view. For this reason, we were already hiding the origins
sidebar when you navigate to an interstitial while the security panel is
open. This CL extends that behavior to when you open DevTools while an
interstitial is already showing.

As a drive-by, this CL also fixes a bug where requests that finished after
the interstitial was shown would still show up in the sidebar.

Also note that this CL only partially addresses the linked bug. This CL
removes the confusing/useless prompt to reload, but doesn't fix the fact
that refreshing on an interstitial does weird things (sends you back to
the previous page). The latter weirdness has been split into
 https://crbug.com/669316 .

BUG= 637299 
TEST=Navigate to https://expired.badssl.com. Open the DevTools security
panel. Observe that there is no prompt to reload in the sidebar.

Review-Url: https://codereview.chromium.org/2522733002
Cr-Commit-Position: refs/heads/master@{#434887}

[modify] https://crrev.com/f8d89eaf15d68b685f1d1e0503a2057df1082a75/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/f8d89eaf15d68b685f1d1e0503a2057df1082a75/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/f8d89eaf15d68b685f1d1e0503a2057df1082a75/third_party/WebKit/LayoutTests/http/tests/inspector/security/interstitial-sidebar.html
[modify] https://crrev.com/f8d89eaf15d68b685f1d1e0503a2057df1082a75/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/f8d89eaf15d68b685f1d1e0503a2057df1082a75/third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js

Comment 5 by est...@chromium.org, Dec 13 2016

Status: Fixed (was: Started)
Closing this based on the commit in comment 4; there's still the non-security-panel specific follow-up  issue 669316  (having devtools open somehow breaks refresh on interstitials).

Sign in to add a comment