New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637288 link

Starred by 3 users
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ junov@chromium.org
ccameron@chromium.org
█ zakerinasab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 634542
issue 637287



Sign in to add a comment

Canvas color management: fate of legacy-srgb

Project Member Reported by junov@chromium.org, Aug 12 2016 
Before shipping the canvas colorSpace feature, we nee to decide whether the legacy-srgb colorSpace is needed and remove it if necessary.

If at time of shipping the implementation of colormanagement for the rest of blink is complete, we probably will not need the leagacy-srgb color space.

Comment 1 by arthur.w...@gmail.com, Sep 7 2017 

I suspect this bug accidentally got orphaned during the bug migration. Commenting to point this out. Sorry if that was in error.

Comment 2 by junov@chromium.org, Sep 7 2017

Cc: junov@chromium.org ccameron@chromium.org
Owner: zakerinasab@chromium.org
Now that color-correct rendering has shipped on all platforms in Chrome-61, we should be able to remove legacy-srgb for from the code base.  There is still a run-time option for turning off color-correct rendering though, so we may want to wait for that to be removed.

Comment 3 by fs...@chromium.org, Oct 12 2017

Cc: zakerinasab@chromium.org
 Issue 765948  has been merged into this issue.

Comment 4 by zakerinasab@chromium.org, Oct 25 2017

Labels: -Pri-3 Pri-1

Comment 5 by zakerinasab@chromium.org, Oct 25 2017

Labels: -Pri-1 Pri-2
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f64acb0ba061a63b153e935da0abe94b0d369d

commit 84f64acb0ba061a63b153e935da0abe94b0d369d
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Tue Oct 31 19:12:23 2017

Remove legacy-srgb from the code base

This change removes legacy-srgb mode from the code base.

Bug:  637288 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibaee28da77fdc9e216cc055e74e6725255eebc29
Reviewed-on: https://chromium-review.googlesource.com/738534
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512900}
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedColorParams.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedColorParams.h
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/core/html/ImageData.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/core/html/ImageDataColorSettings.idl
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/modules/canvas/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DSettings.idl
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/platform/graphics/CanvasColorParams.cpp
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/platform/graphics/CanvasColorParams.h
[modify] https://crrev.com/84f64acb0ba061a63b153e935da0abe94b0d369d/third_party/WebKit/Source/platform/graphics/UnacceleratedImageBufferSurface.h

Comment 7 by zakerinasab@chromium.org, Oct 31 2017

Status: Fixed (was: Assigned)

Comment 8 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment