Mock (attached) has been approved by UI review.

Deleted: 03.png 164 KB

	03.png 164 KB View Download

Where should the url for "Learn more" go?

Should this only be displayed if we have an "Articles for you" section? Should it be _in_ that section then?

I'll get you a vanity URL asap.

When there is extra bottom space, I expect it should go below "Learn more"?

Linking only part of the text is painful for translations. Can we link the whole text?

Will the link need to point to a localized version, using the device? Then we need to parameterize that.

I meant: _using the device language_

Discussed #11 offline (we can link part of the text).

#12/#13: Latest guidance for Help Center articles is _not_ to use localized URLs; the server can redirect to a different language based on the language headers set by the browser.

Thanks both!

Bernhard is right. I'm in the process of getting you the right "p-link". You may have seen this in other parts of the code: we use parameterized helpcenter URLs to point to specific articles. This is to avoid friction when absolute URLs change. The server then appends the hl=language_code parameter on the fly.

//Linking only part of the text is painful for translations. Can we link the whole text?

How painful? This is the visual design we got approved.

I now know how to link part of the text. It's something we do elsewhere in Chrome already, so no issue. Thanks all!

Don't worry, we figured out a way to add a link to part of the text :)

Perfect, thanks! :)

Please link to https://support.google.com/chrome/?p=new_tab

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35978862e4fc752f742ab01d6ab0883b99cfd374

commit 35978862e4fc752f742ab01d6ab0883b99cfd374
Author: mvanouwerkerk <mvanouwerkerk@chromium.org>
Date: Fri Aug 26 17:16:05 2016

Ntp: show footer with learn more link.

BUG= 637257 

Review-Url: https://codereview.chromium.org/2275693003
Cr-Commit-Position: refs/heads/master@{#414738}

[add] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/res/layout/new_tab_page_footer.xml
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/res/layout/new_tab_page_snippets_header.xml
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[add] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/java_sources.gni
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/35978862e4fc752f742ab01d6ab0883b99cfd374/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

I didn't add UMA for clicking on the "learn more" link yet, but there's a TODO in the code for that. Shall we mark this bug as fixed?

Yes (because we track the behavior as launch blocking). But please do file
a new one for UMA for M55.

Ok, there's now issue 641412 for uma tracking.

Your change meets the bar and is auto-approved for M54 (branch: 2840)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73225c1a548b1fb20c2fedee56ea22d40809914d

commit 73225c1a548b1fb20c2fedee56ea22d40809914d
Author: Marc Treib <treib@chromium.org>
Date: Wed Aug 31 09:20:13 2016

Ntp: show footer with learn more link.

BUG= 637257 

Review-Url: https://codereview.chromium.org/2275693003
Cr-Commit-Position: refs/heads/master@{#414738}
(cherry picked from commit 35978862e4fc752f742ab01d6ab0883b99cfd374)

Review URL: https://codereview.chromium.org/2291273003 .

Cr-Commit-Position: refs/branch-heads/2840@{#65}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/res/layout/new_tab_page_footer.xml
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/res/layout/new_tab_page_snippets_header.xml
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[add] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java_sources.gni
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Tested this issue on Ubuntu 14.04 using chrome latest Dev M54-54.0.2840.8. Observed no "Learn more" link is seen in the footer by opening NTP page.

mvanouwerkerk@ - Do we have any manual repro steps for this issue to verify it from Chrome-TE end?

This is an Android only implementation. No idea why the Linux box was ticket.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73225c1a548b1fb20c2fedee56ea22d40809914d

commit 73225c1a548b1fb20c2fedee56ea22d40809914d
Author: Marc Treib <treib@chromium.org>
Date: Wed Aug 31 09:20:13 2016

Ntp: show footer with learn more link.

BUG= 637257 

Review-Url: https://codereview.chromium.org/2275693003
Cr-Commit-Position: refs/heads/master@{#414738}
(cherry picked from commit 35978862e4fc752f742ab01d6ab0883b99cfd374)

Review URL: https://codereview.chromium.org/2291273003 .

Cr-Commit-Position: refs/branch-heads/2840@{#65}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[add] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/res/layout/new_tab_page_footer.xml
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/res/layout/new_tab_page_snippets_header.xml
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java
[add] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/java_sources.gni
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/73225c1a548b1fb20c2fedee56ea22d40809914d/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java