New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637250 link

Starred by 1 user
Status: Fixed
Owner:
█ pke@google.com
Email to this user bounced
Closed: Aug 2016
Cc:
█ noyau@chromium.org
treib@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocked on:
issue 633139


Sign in to add a comment

Register all CSuggestionsProviders in IOSChromeContentSuggestionsServiceFactory

Project Member Reported by pke@google.com, Aug 12 2016 
Make the IOSChromeContentSuggestionsServiceFactory the equivalent of the ContentSuggestionsServiceFactory (except for the missing OfflinePageSuggestionsProvider).
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 12 2016

Labels: Hotlist-Google

Comment 2 by pke@google.com, Aug 25 2016

Labels: -M-55 M-54 zine-16-08-22
Status: Fixed (was: Assigned)
The following revision should refer to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9f49e317107c0a827f559f4a2da1050dd207358

commit c9f49e317107c0a827f559f4a2da1050dd207358
Author: pke <pke@google.com>
Date: Thu Aug 25 13:21:37 2016

Register all providers in IOSChromeContentSuggestionsServiceFactory

Create the articles provider (NTPSnippetsService) and the
BookmarkSuggestionsProvider in the
IOSChromeContentSuggestionsServiceFactory and register them with
the ContentSuggestionsService.

This makes the IOSChromeContentSuggestionsServiceFactory equivalent
to the ContentSuggestionsServiceFactory again (apart from the
OfflinePageSuggestionsProvider, which is Android-only).

BUG=  633139  

Review-Url: https://codereview.chromium.org/2232473002
Cr-Commit-Position: refs/heads/master@{#414415}

[modify] https://crrev.com/c9f49e317107c0a827f559f4a2da1050dd207358/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
►

Sign in to add a comment