New issue
Advanced search Search tips

Issue 637247 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Remove LayoutOptionForRTLSupport

Project Member Reported by gambard@chromium.org, Aug 12 2016

Issue description

I think LayoutOptionForRTLSupport() in rtl_geometry.h is now useless with the support of iOS9+ only.

Can we remove it?
 

Comment 1 by marq@chromium.org, Oct 15 2016

Cc: marq@chromium.org
Owner: ----
Status: Available (was: Assigned)
Components: UI>Internationalization>RTL
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by marq@chromium.org, Apr 13 2018

Cc: -marq@chromium.org
Owner: marq@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89d79c17e65fe9903c903ac88cad65e581430c65

commit 89d79c17e65fe9903c903ac88cad65e581430c65
Author: Mark Cogan <marq@google.com>
Date: Tue Apr 17 11:12:08 2018

[iOS] Remove obsolete constraint and RTL utilities.

This CL removes the obsolete-after-iOS8 LayoutOptionForRTLSupport() utility method.

Since that was the major use case for many of the "option" variants of AddConstraint methods,
they were converted to the fewer-parameter version, and other obsolete variants were also
cleaned up.

Bug:  637247 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I961204c1620d354b2c3c3461baa65a8d903e8c5b
Reviewed-on: https://chromium-review.googlesource.com/1013569
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551293}
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/alert_coordinator/loading_alert_coordinator.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/incognito_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_handset_view_controller.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/generic_section_header_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/panel_bar_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/session_section_header_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/session_tab_data_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/show_full_history_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_in_progress_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_on_no_sessions_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/ntp/recent_tabs/views/spacers_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/rtl_geometry.h
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/rtl_geometry.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/tab_switcher/tab_switcher_header_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/tabs/tab_view.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/util/constraints_ui_util.h
[modify] https://crrev.com/89d79c17e65fe9903c903ac88cad65e581430c65/ios/chrome/browser/ui/util/constraints_ui_util.mm

Comment 6 by marq@chromium.org, Apr 24 2018

Status: Fixed (was: Assigned)

Sign in to add a comment