New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637245 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

fast/html/details-* tests failing on Mac10.11 Retina.

Project Member Reported by kolos@chromium.org, Aug 12 2016

Issue description

First failed build is https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/13516 

Suspected CLs:
1) blink auto-rebaseline for r411560 (wkorman@chromium.org). It is from the previous build, but it changes "video-layer-crash" and "video-transformed" stuff (https://codereview.chromium.org/2239283002).

2) cc: Add gfx::ColorSpace to cc::ResourceProvider resource creation (https://codereview.chromium.org/2235623003)

3) Removed unused destroy() methods in CSSValue and StyleRule (https://codereview.chromium.org/2230813003)

wkorman@chromium.org, ccameron@, sashab@: please have a look if your CLs might break these tests. Thank you. 
 

Comment 1 by kolos@chromium.org, Aug 12 2016

Labels: Sheriff-Chromium

Comment 2 by kolos@chromium.org, Aug 12 2016

Description: Show this description
Cc: wkorman@chromium.org
 Issue 637255  has been merged into this issue.
Cc: -sashab@chromium.org -ccameron@chromium.org
I have marked them as flaky, it is most likely caused by the wkorman's CL here:
https://codereview.chromium.org/2217263003
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-1-and-click.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-add-summary-3-and-click.html

The above tests seems to be flaky on mac retina
Thanks for fielding, I will look into this.
Cc: pdr@chromium.org ccameron@chromium.org
Components: Blink>Paint
Labels: OS-Mac
Unable to repro any flakiness on Mac Pro desktop non-retina OSX 10.11.6 simulating retina config via --enable-prefer-compositing-to-lcd-text as add'l driver flag to layout test runner, --repeat-each=100.

See also my comment on another bug rebased:  http://crbug.com/637251#c3 

Am wondering whether my change has tickled some other issue re: not-consistently-reset-state that leads to flakiness when other tests are executed ahead of these. For example pdr@ recently landed http://crrev.com/2208603004 though I don't think this issue is related to that.

Also +ccameron in case it turns out to be his CL rather than mine. Still investigating.

Comment 9 by pdr@chromium.org, Aug 12 2016

A bit of a tangent but I really wish we had a way to track the issues of leaving state around between test runs. Every one of these sits around in the tree for a few weeks before anyone gets worked up enough to fix it, then they take at least a full day to really track down because there's no way to blame the original patch. We have the infrastructure that notices when a test passes on retry, but no way to track which preceding test could be causing it.
Direct link to layout test failures noted for Mac10.11 Retina fast/html/details-*:

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/5617/layout-test-results/results.html

Actual results for fast/html/details-add-summary-* are as if the click on the 'summary' tag is simply not firing, or if it is, the content isn't being invalidated/repainted.
The auto-rebaseline http://crrev.com/2239283002 has bad rebaseline image for mac-retina details-add-summary-1-and-click-expected.png.

On non-Retina but with --enable-prefer-compositing-to-lcd-text and --reset-results we generate a correct expectation image, and --repeat-each=100 still shows no flakiness. Possibly a bad Retina rebaseline?

I'm preparing a build on my Retina laptop currently.
Cc: trchen@chromium.org
In case related, trchen@ notes he is reverting a change http://crrev.com/2229303002/ that landed around midnight last night, so roughly similar timeframe to my change, and could have introduced flakiness into LayoutTests.
Labels: -Sheriff-Chromium
This looks like its being worked on, removing the Chromium-Sheriff label. Please revert ASAP to fix this test.
Summary: fast/html/details-* tests failing on Mac10.11 Retina. (was: media/video-transformed.html and media/video-layer-crash.html failures on Win10)
Finally got back to this. It's been a while. Running https://codereview.chromium.org/2404073002/ through trybots to see current state.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85149a47ba2c6e35561cb662a2cdc728f2e906cf

commit 85149a47ba2c6e35561cb662a2cdc728f2e906cf
Author: wkorman <wkorman@chromium.org>
Date: Wed Oct 12 01:30:01 2016

Re-enable fast/html/details* tests.

Passes Mac10.11 Retina trybot. Running tests locally with these baselines removed on a Mac Retina laptop passes. Running one test 100 times shows 100% pass rate.

BUG= 637245 
TBR=pdr

Review-Url: https://codereview.chromium.org/2404073002
Cr-Commit-Position: refs/heads/master@{#424636}

[modify] https://crrev.com/85149a47ba2c6e35561cb662a2cdc728f2e906cf/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-1-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-1-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-10-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-10-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-2-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-2-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-3-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-3-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-4-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-4-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-5-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-5-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-6-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-6-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-7-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-7-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-8-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-8-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-9-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-add-summary-9-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-1-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-1-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-2-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-2-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-3-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-3-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-4-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-4-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-5-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-5-and-click-expected.txt
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-6-and-click-expected.png
[delete] https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc/third_party/WebKit/LayoutTests/platform/mac-retina/fast/html/details-remove-summary-6-and-click-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment