Line height changes in the WebUI CBD dialog after checking checkbox |
|||||||
Issue descriptionIn the old WebUI CBD dialog (chrome://settings/clearBrowserData), checking a checkbox that has an associated counter expands the row of that checkbox, and in turn slightly increases the height of the entire dialog. See the attached screenshots. This is a recent regression in M53 probably caused by https://codereview.chromium.org/2180383002/ which increased the line-height of the counter to 1.4. This means that checkboxes whose counter is visible have higher line height than those whose counter is not.
,
Aug 15 2016
This has been checked in a couple of days ago (https://codereview.chromium.org/2240903002/, no idea why this bug isn't updated), and is in the current canary. Requesting permission to merge back into M53.
,
Aug 16 2016
Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary and safe to merge?
,
Aug 16 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 16 2016
Please merge your change to M53 branch 2785 before 5:00 PM PT today (Tuesday) so we can take it for tomorrow's beta release. Thank you.
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a8ffdc08c46628f0dee3d70987c4d6d302e6757 commit 0a8ffdc08c46628f0dee3d70987c4d6d302e6757 Author: John Rummell <jrummell@chromium.org> Date: Tue Aug 16 20:05:51 2016 Merge "Improve line spacing in Clear Browsing Data dialog" The additional line space needs to apply to the whole text next to the checkbox, rather than just the optional text when selected. Doing this to avoid the text shifting when the checkbox is selected/deselected. BUG= 637237 TEST=tested "Clear Browsing Data" dialogs manually CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2240903002 Cr-Commit-Position: refs/heads/master@{#411820} (cherry picked from commit 62e9dd034866c1aa641a6c8280406f1e32e21dbd) Review URL: https://codereview.chromium.org/2256433002 . Cr-Commit-Position: refs/branch-heads/2785@{#629} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/0a8ffdc08c46628f0dee3d70987c4d6d302e6757/chrome/browser/resources/options/clear_browser_data_overlay.css
,
Aug 17 2016
Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 53.0.2785.70.Line height does not change in the WebUI CBD dialog after checking checkbox in chrome://settings/clearBrowserData. Please find attached screencast. Marking it as TE-Verified.
,
Aug 17 2016
,
Oct 20 2016
Verified on ChromeOS 8872.18.0, 55.0.2883.20 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jrumm...@chromium.org
, Aug 12 2016