Static initializer check should be a trybot check, not just a perf bot check |
|||||||||||
Issue descriptionEncountered here: https://codereview.chromium.org/2243433002/ Apparently the check for static initializers runs as a perfbot check, but not as a buildbot check. This allows code with static initializers to land and subsequently breaks the perf waterfall and requires manual rollback. Since static initializers are forbidden, we should have a presubmit check that guarantees there aren't any. Having been guilty of adding static initializers by accident several times I think this is a fairly important QoL thing, and I'm really surprised at the current behaviour. Not sure where this bug belongs, infra can you triage?
,
Aug 12 2016
+rsesek@, +phajdan.jr@, both of who worked on https://chromium.googlesource.com/chromium/src/+log/master/infra/scripts/legacy/scripts/slave/chromium/sizes.py Infra-Troopers is generally used for breakages and outages. If something needs triaging, it should be added to a triage queue (e.g., Infra component).
,
Aug 16 2016
Pawel, could you take a look at this?
,
Aug 17 2016
,
Sep 23 2016
,
Feb 14 2017
,
Feb 28 2017
Build-CommitQueue has been long deprecated, but until now was still offered in auto-complete. Please use Infra>CQ component for CQ-related issues instead.
,
Jun 13 2017
,
Jun 14 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2018
,
Jun 15 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by sullivan@chromium.org
, Aug 12 2016