Regression : Unable to Remove History Entry on clicking 'Remove from History' option |
||||||
Issue descriptionVersion: 54.0.2827.0 OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome -> Open to 2-3 webpages ->Go to chrome://history page (2)Clcik on 'More options' -> Now select 'Remove from History' option and observe Expected: Should be able to Remove History Entry on clicking 'Remove from History' option Actual: Instead Unable to Remove History Entry on clicking 'Remove from History' option This is Regression Issue broken in M-54 will provide bisect info soon
,
Aug 12 2016
Attaching Expected and actual Videos Adding Dev Blocker as this is a Recent Regression on M54. Please feel free to remove if not required Manual good and Bad Builds: Good Build: 54.0.2826.0 Bad Build: 54.0.2827.0 Below is the Bisect info : CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/6554045543b20db3e810925f3cda0f0d93e4bae6..3e1eed893f3fe23256d5c418eecfc72ddd95fb8b Suspecting https://codereview.chromium.org/2207323002 from above Changelog @calamity: Please feel free to re-assign if its not related to your change
,
Aug 14 2016
In history_item.js, onMenuButtonTap_function fires "toogle_menu" event with history entry coming from backend. But onRemoveFromHistoryTap_ in list_container.js requires item's |path| property computed by polymer (pathForItem_) in order to remove view. So before firing event, path property should be set on backend object.
,
Aug 15 2016
,
Aug 15 2016
Its affecting only Material Design for History page. Able to remove the entry on a regular History page successfully upon disabling the flag "Enable Material Design history" in chrome://flags.
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d276ca3e0873ddd68d41de237606d057c20df4b commit 4d276ca3e0873ddd68d41de237606d057c20df4b Author: calamity <calamity@chromium.org> Date: Tue Aug 16 01:50:57 2016 [MD History] Fix the 'Remove from history' button. This CL fixes the 'Remove from history' button which was broken by r411253 and adds a test. BUG= 637199 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2246033002 Cr-Commit-Position: refs/heads/master@{#412129} [modify] https://crrev.com/4d276ca3e0873ddd68d41de237606d057c20df4b/chrome/browser/resources/md_history/history_item.js [modify] https://crrev.com/4d276ca3e0873ddd68d41de237606d057c20df4b/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/4d276ca3e0873ddd68d41de237606d057c20df4b/chrome/test/data/webui/md_history/history_list_test.js
,
Aug 16 2016
,
Aug 19 2016
,
Aug 19 2016
Issue 638527 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by brajkumar@chromium.org
, Aug 12 2016Status: Untriaged (was: Unconfirmed)