New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 637196 link

Starred by 3 users
Status: Fixed
Owner:
calamity@chromium.org
Closed: Aug 2016
Cc:
ajha@chromium.org
calamity@chromium.org
█ kavvaru@chromium.org
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ tkonch...@chromium.org
█ ranjitkan@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary chrome://history page shifted downwards after restarting browser.

Reported by dmascare...@etouch.net, Aug 12 2016 
Chrome Version:54.0.2827.0 (Official Build) 7e8f79d3410922d7e9c712062f249a4577359c63-refs/heads/master@{#411497}
OS: Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history
2. Open Ntp and restart the browser (chrome://restart)
3. Then navigate to chrome://history and observe.

Actual:  Unnecessary chrome://history page shifted downwards.
Expected: chrome://history page should be properly seem after step 3.

This is regression issue, broken in 'M 54' and will soon update the bisect info.

Comment 1 by dmascare...@etouch.net, Aug 12 2016

Labels: hasbisect
Owner: calamity@chromium.org
Status: Assigned (was: Untriaged)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/d06a12d4cf219e1c310cdc736736f35d6168de49..3e1eed893f3fe23256d5c418eecfc72ddd95fb8b?pretty=fuller&n=1000

Suspecting: r411253

Good build:54.0.2826.0
Bad build:54.0.2827.0

Note: Issue is reproducible on Mac OS and Linux OS.
Actual_his.png
34.5 KB View Download
Actual.mp4
1.3 MB View Download

Comment 2 by ranjitkan@chromium.org, Aug 12 2016

Labels: ReleaseBlock-Beta
Adding release block label, please undo if not the case.

Comment 3 by dmascare...@etouch.net, Aug 12 2016

Labels: OS-Linux OS-Mac

Comment 4 by nyerramilli@chromium.org, Aug 17 2016 

calamity@, could you please check and update.

Comment 5 by calamity@chromium.org, Aug 18 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/515e6066fbb3c7a44317ba86b8033a6c10ff03c4

commit 515e6066fbb3c7a44317ba86b8033a6c10ff03c4
Author: ahmetemiremir <ahmetemiremir@gmail.com>
Date: Thu Aug 18 10:01:22 2016

Fixes broken history page when no item selected.

There are situations where getSelectedList_ returns nothing and unselectAllItems
triggered by polymer fails if nothing is selected.Page shifted downwards since
polymer can't generate custom style for history-sidebar after the failure.

BUG= 637196 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248223003
Cr-Commit-Position: refs/heads/master@{#412780}

[modify] https://crrev.com/515e6066fbb3c7a44317ba86b8033a6c10ff03c4/AUTHORS
[modify] https://crrev.com/515e6066fbb3c7a44317ba86b8033a6c10ff03c4/chrome/browser/resources/md_history/list_container.js

Comment 7 by calamity@chromium.org, Aug 19 2016

Cc: kavvaru@chromium.org calamity@chromium.org durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 638524  has been merged into this issue.

Comment 8 by calamity@chromium.org, Aug 19 2016

Status: Fixed (was: Started)

Comment 9 by calamity@chromium.org, Aug 23 2016 

 Issue 638863  has been merged into this issue.

Comment 10 by tkonch...@chromium.org, Aug 23 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-M54 TE-Verified-54.0.2837.0
Tested the same on win10, mac 10.11.5 and Linux 14.04 chrome version 54.0.2837.0 - chrome://history page displayed fine after step 3

Please find the screenshot

Adding TE-Verified labels
Screen Shot 2016-08-23 at 11.34.29 AM.png
245 KB View Download
►

Sign in to add a comment