Avoid using Element.getInnerText() in GWT |
||
Issue descriptionIn most cases, we want to directly use javascript's innerText rather than GWT's implementation of Element::getInnerText(), which is intentionally different to mimic an old IE behaviour, which returns text within <script> or <noscript> tags. Even though we already have DomUtil.getInnerText(), we might need a way to automatically detect all usage of Element::getInnerText(), just to avoid using it accidentally. The following bug was a result of accidental misuse: https://bugs.chromium.org/p/chromium/issues/detail?id=613374#c2
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1730009565e394ff8c0ad04121d2e44d0c3d166 commit d1730009565e394ff8c0ad04121d2e44d0c3d166 Author: wychen <wychen@chromium.org> Date: Fri Aug 12 23:10:17 2016 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/6c16f14405...91f9f016e0 Picked up changes: 91f9f01 Fix figcaption generation 365c44e Add support for figure element f8f3308 Update distillability modeling scripts to predict long articles 8a12e18 Decrease mismatches in feature extraction 4d7ab13 Extract image URLs in WebTables 8d8063a Extract image URLs in srcset as well 34c4a18 Re-enable tests containing <track> in CI 0d4286b The display style of WebText root element should never be inline BUG= 531545 ,539851, 595120 , 610944 , 613374 ,625621,631086, 637170 Review-Url: https://codereview.chromium.org/2245763002 Cr-Commit-Position: refs/heads/master@{#411811} [modify] https://crrev.com/d1730009565e394ff8c0ad04121d2e44d0c3d166/DEPS [modify] https://crrev.com/d1730009565e394ff8c0ad04121d2e44d0c3d166/third_party/dom_distiller_js/README.chromium
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be54205fd0475ee4de5585a3ee986b34b089bff3 commit be54205fd0475ee4de5585a3ee986b34b089bff3 Author: wychen <wychen@chromium.org> Date: Wed Aug 31 00:12:24 2016 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/b21e6a334a...d16a68c1b8 Picked up changes: d16a68c Fix partially hidden article 85447bd Ignore exceptions in embed extractors 50efabe Skip unrecognized iframes 23830cf Use .innerText in text-only mode 7306201 Avoid creating container when possible 5323f43 Forbid usage of GWT's Element.getInnerText() BUG=599121, 637170 ,641678 Review-Url: https://codereview.chromium.org/2297023002 Cr-Commit-Position: refs/heads/master@{#415507} [modify] https://crrev.com/be54205fd0475ee4de5585a3ee986b34b089bff3/DEPS [modify] https://crrev.com/be54205fd0475ee4de5585a3ee986b34b089bff3/third_party/dom_distiller_js/README.chromium
,
Aug 31 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by wychen@chromium.org
, Aug 12 2016