New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Show progress spinner when waiting for shipping options update

Project Member Reported by rouslan@chromium.org, Aug 12 2016

Issue description

When user selects a shipping option in PaymentRequest UI, show a spinner. The merchant may need to round trip to a server to calculate the total, which may take considerable time, especially on slow networks.
 
spin.mp4
7.9 MB View Download
Labels: Merge-Request-53 M-53
Fixed in http://crrev.com/2244543002. Don't know why that has not been logged on this bug report.

Would like to merge http://crrev.com/2244543002 into M-53.

Comment 3 by dimu@chromium.org, Aug 16 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff3b7f84def51f58feebcd9e103e978219994b5

commit 6ff3b7f84def51f58feebcd9e103e978219994b5
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue Aug 16 15:46:09 2016

[Merge M-53] Show progress spinner when waiting for shipping options update.

When user selects a shipping option in PaymentRequest UI, show a
spinner. The merchant may need to round trip to a server to calculate
the total, which may take considerable time, especially on slow
networks.

BUG= 637165 

Review-Url: https://codereview.chromium.org/2244543002
Cr-Commit-Position: refs/heads/master@{#411785}
(cherry picked from commit b06d2272aecb90f72d35c687fbd1ef22368762e6)

Review URL: https://codereview.chromium.org/2255473002 .

Cr-Commit-Position: refs/branch-heads/2785@{#625}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/6ff3b7f84def51f58feebcd9e103e978219994b5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/6ff3b7f84def51f58feebcd9e103e978219994b5/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment