Reverts do not immediately land in PolyGerrit |
||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Revert a change 2. CQ the change What is the expected output? The change will land What do you see instead? The change doesn't land Please provide any additional information below. See https://chromium-review.googlesource.com/c/368510 for example. TBR doesn't seem to be working :(
,
Aug 12 2016
Ravi, isn't this something you've been working on? If not, re-assign back to me or mark untriaged.
,
Aug 12 2016
FTR, the only thing missing right now is that REVERT buttong doesn't set self-LGTM on the change, that is Code-Review+1 is missing.
,
Aug 12 2016
No, not yet. But this is something that is obviously important to fix for reverts. Leaving it untriaged in case somebody gets to it before me.
,
Aug 12 2016
Thanks for speedy reply. Let's keep it available since it has clearly been triaged just now :) Also, this is Pri1.
,
Sep 27 2016
Ravi, mark this as fixed if it is. I know you did work around this in the chromium gerrit plugin.
,
Sep 28 2016
,
Sep 28 2016
Andy, any pointers on how to automatically set Code-Review+1 when a new revert issue is created?
,
Sep 28 2016
You could make a request to the REST API to set the label via a plugin.
,
Sep 29 2016
One other method would be to add the ability to Gerrit to set labels on the new change that will be created. This would require adding a `labels` field to RevertInput, then using those to create a new change. https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#revert-input I think this is the best way to go, actually.
,
Sep 29 2016
I have an approach I am working on that is slightly different and does not require an API change. But I think it will make adding labels to the revert call easy if 'labels' are added in the future to RevertInput. I will send it out for review later today and we can discuss there.
,
Sep 29 2016
,
Sep 29 2016
Renaming issue
,
Sep 29 2016
,
Sep 29 2016
Sent out for review https://critique.corp.google.com/#review/134671402
,
Oct 6 2016
https://critique.corp.google.com/#review/134671402 has been submitted and the change is now live. I did observe that sometimes after you hit revert you do not see the labels show up right away. The labels are applied and the change does get submitted, but the initial redirect to the issue does not show this because the /revisions/current/review REST API has a small lag. This experience will be improved whenever gerrit:4671 is resolved. Andy, let me know if you have another way to solving this. Marking this as fixed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by andyb...@chromium.org
, Aug 12 2016Labels: Proj-Gerrit-Migration
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)