New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

DevTools workers get terminated occasionally

Project Member Reported by alph@chromium.org, Aug 12 2016

Issue description

DevTools workers get terminated occasionally
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68f462e0eee7ce6a4befad62fee5fb76bc61da4

commit e68f462e0eee7ce6a4befad62fee5fb76bc61da4
Author: alph <alph@chromium.org>
Date: Fri Aug 12 04:56:04 2016

DevTools: Make sure the worker instance is not collected while the promise is in flight.

BUG= 637161 

Review-Url: https://codereview.chromium.org/2239753003
Cr-Commit-Position: refs/heads/master@{#411553}

[modify] https://crrev.com/e68f462e0eee7ce6a4befad62fee5fb76bc61da4/third_party/WebKit/Source/devtools/front_end/common/Worker.js

Comment 2 by alph@chromium.org, Aug 12 2016

Status: Fixed (was: Assigned)
Symptoms of the bug are that some worker-based activities may hang. E.g. when taking a heap snapshot it may occasionally stuck in the loading state.

Comment 3 by alph@chromium.org, Aug 12 2016

Labels: -Pri-3 Merge-Request-53 Pri-1

Comment 4 by alph@chromium.org, Aug 12 2016

Description: Show this description

Comment 5 by alph@chromium.org, Aug 12 2016

Summary: DevTools workers get terminated occasionally (was: DevTools workers get terminated ocasionally)

Comment 6 by dimu@chromium.org, Aug 13 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 16 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by alph@chromium.org, Aug 18 2016

Labels: -Hotlist-Merge-Approved -Merge-Approved-53 Merge-Merged M-53 M-54
Cc: tkonch...@chromium.org
Labels: TE-Verified-M54 TE-Verified-54.0.2832.2
Tested the same on win10, mac 10.11.6 and Linux 14.04 using chrome version 54.0.2832.2 - Tried taking a heap snapshot and works fine

Please find the screenshot

Fix works as expected
Screen Shot 2016-08-19 at 12.18.56 PM.png
2.3 MB View Download
Labels: TE-Verified-M53 TE-Verified-53.0.2785.80
Tested the same on win10, mac 10.11.6 and Linux 14.04 using chrome version 53.0.2785.80 - Tried taking a heap snapshot and works fine without any hang.

Please find the screenshot

Fix merged to M53 successfully.
Screen Shot 2016-08-24 at 11.29.54 AM.png
2.1 MB View Download

Sign in to add a comment