New issue
Advanced search Search tips

Issue 637070 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Change Settings strings for Android apps on Chromebooks

Project Member Reported by jhorwich@chromium.org, Aug 11 2016

Issue description

This is a tracking bug for changing the strings used in chrome://settings on Google Play-enabled Chrome OS devices.

Changing "Android apps" section header to "Google Play Store"
Changing "Enable Android apps on your Chromebook" to "Enable Google Play Store on your Chromebook"
Changing "Manage your Android apps in <link>Settings</link>" to "Manage your Android <link>preferences</link>"

All functionality remains the same, just re-wording things to line up with documentation.

This has already been implemented in master via https://codereview.chromium.org/2237573004/ and we will like to merge this to M53 branch.
 
Labels: Merge-Request-53

Comment 2 by gov...@chromium.org, Aug 15 2016

Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary and safe to merge?

Comment 3 by gov...@chromium.org, Aug 15 2016

Labels: OS-Chrome
A note, this is a strings-only change to chromeos_strings.grdp and I've been able to spot-check it on a locally-built Chrome build via simplechrome workflow - Chrome PFQ rolls have held up the canary builds on this one.

Comment 5 by gov...@chromium.org, Aug 15 2016

Labels: -Merge-Request-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #4 and internal mail thread. Please merge ASAP. Thank you.
Labels: -Merge-Approved-53 merge-merged-2785
Status: Fixed (was: Untriaged)
Forgot to edit patch description to reference this bug, but here is the relevant details from the merge to m53 branch. It is at Cr-Commit-Position: refs/branch-heads/2785@{#616}

Reviewers: 
CL: https://codereview.chromium.org/2253453002/

Message:
Committed patchset #1 (id:1) manually as
722a2f31816c33b084fc3f15b9a37de0e5cd32b2.

Description:
Change chrome://settings strings for ARC OptIn.

Simple wording changes to strings in chrome://settings related to ARC
OptIn section, to align with other documentation.

BUG=b:30773667
TEST=Visit chrome://settings

Review-Url: https://codereview.chromium.org/2237573004
Cr-Commit-Position: refs/heads/master@{#411382}
(cherry picked from commit 7aaac36d6f2dc840e9857baab6a324b53de718ce)

Committed:
https://chromium.googlesource.com/chromium/src/+/722a2f31816c33b084fc3f15b9a37de0e5cd32b2

Base URL: https://chromium.googlesource.com/chromium/src.git@2785

Affected files (+5, -5 lines):
M chrome/app/chromeos_strings.grdp

Status: Verified (was: Fixed)

Sign in to add a comment