New issue
Advanced search Search tips

Issue 637069 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Aug 2016
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

fast/repaint/block-layout-inline-children-replaced.html Needs rebaseline but is still image flakey

Project Member Reported by schenney@chromium.org, Aug 11 2016 
fast/repaint/block-layout-inline-children-replaced.html definitely has the wrong text expectations for most platforms and seems to also be image flakey. The test should be rebased and ideally the flakey image result should be fixed. My guess is that we just need to wait for layout and paint.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e012026419587c9facab8b74a000592b81f82928

commit e012026419587c9facab8b74a000592b81f82928
Author: schenney <schenney@chromium.org>
Date: Thu Aug 11 21:57:28 2016

New bug ID for fast/repaint/block-layout-inline-children-replaced.html failure

TBR=wangxianzhu@chromium.org
BUG= 637069 , 636475 

Review-Url: https://codereview.chromium.org/2243633002
Cr-Commit-Position: refs/heads/master@{#411426}

[modify] https://crrev.com/e012026419587c9facab8b74a000592b81f82928/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by wangxianzhu@chromium.org, Aug 11 2016 

The image flake looks weird. Before finishing the test we call capturePixelAsyncThen() to capture pixels which should do a full document lifecycle update and also rasterization (including deferred decoding if needed).

However, will let the <img> have no src to avoid the effect of deferred image decoding.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cfd5ebf37f9a7b674477f72fdb3cbd761f1ecfa

commit 6cfd5ebf37f9a7b674477f72fdb3cbd761f1ecfa
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Aug 12 00:11:09 2016

Deflake and rebaseline fast/repaint/block-layout-inline-children-replaced.html

BUG= 637069 
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2239113002
Cr-Commit-Position: refs/heads/master@{#411464}

[modify] https://crrev.com/6cfd5ebf37f9a7b674477f72fdb3cbd761f1ecfa/third_party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-replaced-expected.html
[add] https://crrev.com/6cfd5ebf37f9a7b674477f72fdb3cbd761f1ecfa/third_party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-replaced-expected.txt
[modify] https://crrev.com/6cfd5ebf37f9a7b674477f72fdb3cbd761f1ecfa/third_party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-replaced.html
[delete] https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd/third_party/WebKit/LayoutTests/platform/android/fast/repaint/block-layout-inline-children-replaced-expected.txt
[delete] https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/block-layout-inline-children-replaced-expected.txt
[delete] https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt
[delete] https://crrev.com/674177e3bb34ea0747b877e2ce11e41e9a1adfcd/third_party/WebKit/LayoutTests/platform/win/fast/repaint/block-layout-inline-children-replaced-expected.txt

Comment 4 by wangxianzhu@chromium.org, Aug 23 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment