New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637057 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

arc: Sync related issue.

Project Member Reported by lgcheng@google.com, Aug 11 2016

Issue description

If the user is running a version of Chrome that contains the ARC package sync
implementation, but is also running an older version of the Android container
that sends a 0 AndroidID for package update events, and the user already has
some packages installed, the sync service will send these packages with the 0
AndroidID. Then if the user later has a new device, package installation will
fail and the package will stay in 'pending install'. Furthermore, even if the
user manually installs the package, the existing 'pending install' entry will
prevent the sync service from recording the user's new installation correctly.

 

Comment 1 by lgcheng@google.com, Aug 11 2016

http://b/30710474

Comment 2 by lgcheng@google.com, Aug 11 2016

Labels: Merge-Request-53

Comment 3 by gov...@chromium.org, Aug 11 2016

Cc: keta...@chromium.org
Labels: OS-Chrome
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aea7674d6287edb686adb4c91519b04f3af7ac6

commit 2aea7674d6287edb686adb4c91519b04f3af7ac6
Author: lgcheng <lgcheng@google.com>
Date: Thu Aug 11 21:47:08 2016

Fix sync related issue with old container.
Sync related issue when the user is running a version of Chrome that
contains the ARC package sync implementation, but is also running an older
version of the Android container.

BUG= 637057 
Test= Manual test

Review-Url: https://codereview.chromium.org/2217413002
Cr-Commit-Position: refs/heads/master@{#411423}

[modify] https://crrev.com/2aea7674d6287edb686adb4c91519b04f3af7ac6/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Aug 12 2016

Labels: Hotlist-Google

Comment 6 by dimu@chromium.org, Aug 12 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 15 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eadf8dae6f60ccd21b408aec989217b5d1c7b2a

commit 0eadf8dae6f60ccd21b408aec989217b5d1c7b2a
Author: Josh Horwich <jhorwich@chromium.org>
Date: Mon Aug 15 20:05:17 2016

Fix sync related issue with old container. Sync related issue when the user is running a version of Chrome that contains the ARC package sync implementation, but is also running an older version of the Android container.

BUG= 637057 
Test= Manual test

Review-Url: https://codereview.chromium.org/2217413002
Cr-Commit-Position: refs/heads/master@{#411423}
(cherry picked from commit 2aea7674d6287edb686adb4c91519b04f3af7ac6)

Review URL: https://codereview.chromium.org/2242313002 .

Cr-Commit-Position: refs/branch-heads/2785@{#607}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/0eadf8dae6f60ccd21b408aec989217b5d1c7b2a/chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc

Comment 8 by lgcheng@google.com, Aug 15 2016

Status: Fixed (was: Assigned)
Labels: VerifyIn-54
Status: Verified (was: Fixed)
closing

Sign in to add a comment