Filters with no visible content don't render with rtree patch. |
|||
Issue descriptionWhile attempting to reland http://crrev.com/2225563002, sample failure: https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_blink_rel/716/layout-test-results/results.html Affected tests: css3/filters/effect-reference-image.html css3/filters/empty-element-with-filter.html css3/filters/effect-reference-on-transparent-element.html css3/filters/effect-reference-image-lazy-attach.html css3/filters/filterRegions.html Perhaps we'll need to special-case filters in some manner, since we just recently intentionally restructured visual rects so that paired items such as filters adopt a visual rect comprising the union of contained drawings, and if there are none, then I would expect them to have no visual rect and paint nothing.
,
Aug 11 2016
Affected test cases are all svg filter usage. These seem general enough that investigation is warranted, in particular css3/filters/filterRegions.html encompasses many tests that appear to define basic functionality. As expected there are no drawing items and the visual rects on the individual filter display items are now irrelevant, so in cc display item list we're probably just rastering nothing. Not yet sure what best solution to this general issue may be.
,
Aug 11 2016
Believe we need to modify cc visual rect calculation to, in addition to building visual rects based on drawing display items, also incorporate filter bounds. Since filters 'draw actual content' in analogous manner to a drawing. We could generalize drawing/filter display items to something like 'drawsContent' and override cc filter display item visual rect to produce via the filter bounds.
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8062fe31e77b286dfcf0f32127bb5e591449d11f commit 8062fe31e77b286dfcf0f32127bb5e591449d11f Author: wkorman <wkorman@chromium.org> Date: Fri Aug 12 02:04:09 2016 Allow filters to specify their initial visual rect. BUG= 637056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2239913002 Cr-Commit-Position: refs/heads/master@{#411516} [modify] https://crrev.com/8062fe31e77b286dfcf0f32127bb5e591449d11f/cc/blink/web_display_item_list_impl.cc [modify] https://crrev.com/8062fe31e77b286dfcf0f32127bb5e591449d11f/cc/blink/web_display_item_list_impl.h [modify] https://crrev.com/8062fe31e77b286dfcf0f32127bb5e591449d11f/cc/playback/display_item_list.h [modify] https://crrev.com/8062fe31e77b286dfcf0f32127bb5e591449d11f/cc/playback/display_item_list_unittest.cc [modify] https://crrev.com/8062fe31e77b286dfcf0f32127bb5e591449d11f/third_party/WebKit/public/platform/WebDisplayItemList.h
,
Aug 12 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wkorman@chromium.org
, Aug 11 2016