New issue
Advanced search Search tips

Issue 637031 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

git cl try: add -B/--bucket flag to accept bucket name

Project Member Reported by tandrii@chromium.org, Aug 11 2016

Issue description

This has alreayd been done in CQ and CQ_INCLUDE_TRYBOTS.
 
Cc: no...@chromium.org
"tryserver.chromium.linux" is a full master name, but not full bucket name. A full bucket name is "master.tryserver.chromium.linux"
nodir@ wrote in  http://crbug.com/624545#c5 

I think --master should accept master name without "master." prefix. "tryserver.chromium.infra" is a full master name, not to be confused with full bucket name. A full bucket name is "master.tryserver.chromium.infra".

I think we should leave --master for backward compatibility reasons (not prepend "master." prefix) and add -B/--bucket flag that accepts only full bucket name
Re #1: YES YES YES.
Labels: Pri-2
Summary: git cl try: add -B/--bucket flag to accept bucket name (was: git cl try: disallow implicit "master." prefix.)
Labels: Type-Bug
Cc: tandrii@chromium.org
Labels: -Type-Bug Type-Feature
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 8 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by no...@chromium.org, Sep 8 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment