New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

QuiesceStatusChangeChecker doesn't account for CONFIGURING state

Project Member Reported by maxbogue@chromium.org, Aug 11 2016

Issue description

A helpful note from an external dev of a Chromium fork:

"[...]AFAICT the flakiness I observed is caused by the updating sync instance
entering a CONFIGURING state, which will cause
ProfileSyncService::GetActiveDataTypes() to return an empty model type
set, and this in turn will ProgressMarkersMatch() (in the
QuiesceStatusChangeChecker file) to conclude that the engines match state,
and thus that the exit condition have been reached.

I am unsure whether the empty model type set should trigger a false return
 from the matcher, or if QuiesceStatusChangeChecker should check on the
ProfileSyncService::ConfigurationDone status; at present I have gone with
the latter option."

We should fix this.
 
Labels: Sync-Code-Health
Labels: -Sync-Code-Health Hotlist-CodeHealth
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4706b070fab0bee61323c702cb91e3405070cc5

commit c4706b070fab0bee61323c702cb91e3405070cc5
Author: maxbogue <maxbogue@chromium.org>
Date: Mon Jan 23 19:18:17 2017

[Sync] Integ tests can't compare progress markers during configuration.

GetActiveDataTypes() returns an empty set during configuration, so
ProgressMarkersMatch could return a false positive if either service was
in the middle of configuration during a check.

BUG= 637023 

Review-Url: https://codereview.chromium.org/2643643011
Cr-Commit-Position: refs/heads/master@{#445430}

[modify] https://crrev.com/c4706b070fab0bee61323c702cb91e3405070cc5/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc

Status: Fixed (was: Assigned)

Sign in to add a comment