QuiesceStatusChangeChecker doesn't account for CONFIGURING state |
|||
Issue descriptionA helpful note from an external dev of a Chromium fork: "[...]AFAICT the flakiness I observed is caused by the updating sync instance entering a CONFIGURING state, which will cause ProfileSyncService::GetActiveDataTypes() to return an empty model type set, and this in turn will ProgressMarkersMatch() (in the QuiesceStatusChangeChecker file) to conclude that the engines match state, and thus that the exit condition have been reached. I am unsure whether the empty model type set should trigger a false return from the matcher, or if QuiesceStatusChangeChecker should check on the ProfileSyncService::ConfigurationDone status; at present I have gone with the latter option." We should fix this.
,
Oct 6 2016
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4706b070fab0bee61323c702cb91e3405070cc5 commit c4706b070fab0bee61323c702cb91e3405070cc5 Author: maxbogue <maxbogue@chromium.org> Date: Mon Jan 23 19:18:17 2017 [Sync] Integ tests can't compare progress markers during configuration. GetActiveDataTypes() returns an empty set during configuration, so ProgressMarkersMatch could return a false positive if either service was in the middle of configuration during a check. BUG= 637023 Review-Url: https://codereview.chromium.org/2643643011 Cr-Commit-Position: refs/heads/master@{#445430} [modify] https://crrev.com/c4706b070fab0bee61323c702cb91e3405070cc5/chrome/browser/sync/test/integration/quiesce_status_change_checker.cc
,
Jan 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by maxbogue@chromium.org
, Oct 6 2016