IndexedDB: Improve BlobChangeRecord ownership model |
||
Issue descriptionCurrently, BlobChangeRecord instances are held in maps of raw pointers and memory management is manual (delete on remove). This should be replaced by making the containers maps of unique_ptrs and use of base::MakeUnique / std::move as appropriate to avoid any explicit new/delete calls.
,
Aug 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c93fe49115fd12c42c14bb76e33bd45f728d3358 commit c93fe49115fd12c42c14bb76e33bd45f728d3358 Author: jsbell <jsbell@chromium.org> Date: Tue Aug 16 13:34:52 2016 Indexed DB: Hold BlobChangeRecords in maps using smart pointers Don't trust manual new/delete accounting - I hear unique_ptr is a thing. BUG= 637019 , 555865 R=cmumford@chromium.org Review-Url: https://codereview.chromium.org/2245833003 Cr-Commit-Position: refs/heads/master@{#412226} [modify] https://crrev.com/c93fe49115fd12c42c14bb76e33bd45f728d3358/content/browser/indexed_db/indexed_db_backing_store.cc [modify] https://crrev.com/c93fe49115fd12c42c14bb76e33bd45f728d3358/content/browser/indexed_db/indexed_db_backing_store.h
,
Aug 16 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by jsb...@chromium.org
, Aug 12 2016Status: Started (was: Available)