New issue
Advanced search Search tips

Issue 637016 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

Harmony [Mac] - Radio buttons and checkboxes are drawn with the wrong color

Project Member Reported by shrike@chromium.org, Aug 11 2016 
Version: 54.0.2812.0
OS: 10.11

In  Issue 635156 , c#1, I note that the radio buttons in Harmony on the Mac are drawn using the wrong color. estade@ believes it's a Mac issue (he says the other platforms use the correct color). Perhaps they are using a Shiny Modern blue? Checkbox is also using the wrong color.

Please see the following for the correct color:

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20browser%20(MD)/Secondary%20UI%20Previews%20and%20specs%20(exports)#%2FSPEC-secondary-UI-02-radio-checkboxes.png

Comment 1 by ellyjo...@chromium.org, Aug 18 2016

Status: Started (was: Assigned)
This should be a simple fix: all we need to do is stop having a special case for Mac. I put up a CL to remove it.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50b71f849f3ac45cb27559878065926902e992f5

commit 50b71f849f3ac45cb27559878065926902e992f5
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Aug 30 16:42:03 2016

views: use cross-platform border colors

As part of Harmony work, MacViews should switch from using Cocoa's color scheme
to Harmony's.

BUG= 637016 

Review-Url: https://codereview.chromium.org/2256323003
Cr-Commit-Position: refs/heads/master@{#415319}

[modify] https://crrev.com/50b71f849f3ac45cb27559878065926902e992f5/ui/native_theme/native_theme_mac.mm

Comment 3 by shrike@chromium.org, Sep 23 2016 

I believe this is fixed?

Comment 4 by ellyjo...@chromium.org, Sep 26 2016

Status: Fixed (was: Started)
Yes, it is.
►

Sign in to add a comment