"Save video as" context menu should not appear for MSE videos |
||||
Issue descriptionIIUC, "save video" does not work for MSE videos, so the context menu should be disabled in that case. Also see here: https://bugs.chromium.org/p/chromium/issues/detail?id=601947#c2 Dale, could you assign this to the right person? Thanks!
,
Aug 11 2016
Hmm, the right click context menu on desktop has this disabled, so I thought it would carry over to Spitzer as well. qinmin@ do you know how to disable this for the Android download popup menu?
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16006f8e310a6b0da0988b558f661003a8bd262e commit 16006f8e310a6b0da0988b558f661003a8bd262e Author: qinmin <qinmin@chromium.org> Date: Fri Aug 12 22:50:29 2016 Fix an issue that "save video" context menu appears for MSE video We should use media_flags to determine if a video can be saved. BUG= 637010 Review-Url: https://codereview.chromium.org/2239063004 Cr-Commit-Position: refs/heads/master@{#411807} [modify] https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java [modify] https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java [modify] https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e/chrome/browser/ui/android/context_menu_helper.cc
,
Aug 15 2016
Thanks Min!
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cb73c80e01b0a28c76586b25d0f6accd1e09231 commit 0cb73c80e01b0a28c76586b25d0f6accd1e09231 Author: nyquist <nyquist@chromium.org> Date: Mon Aug 15 18:36:33 2016 Revert of Fix an issue that "save video" context menu appears for MSE video (patchset #1 id:1 of https://codereview.chromium.org/2239063004/ ) Reason for revert: Breaks Marshmallow Tablet Tester. See https://crbug.com/637872 for details. Original issue's description: > Fix an issue that "save video" context menu appears for MSE video > > We should use media_flags to determine if a video can be saved. > > BUG= 637010 > > Committed: https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e > Cr-Commit-Position: refs/heads/master@{#411807} TBR=yfriedman@chromium.org,dalecurtis@chromium.org,qinmin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 637010 , 637872 Review-Url: https://codereview.chromium.org/2244343002 Cr-Commit-Position: refs/heads/master@{#411997} [modify] https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java [modify] https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java [modify] https://crrev.com/0cb73c80e01b0a28c76586b25d0f6accd1e09231/chrome/browser/ui/android/context_menu_helper.cc
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de0ea7338899803310109c27050fbbfef958f3f6 commit de0ea7338899803310109c27050fbbfef958f3f6 Author: qinmin <qinmin@chromium.org> Date: Mon Aug 15 20:09:54 2016 Fix an issue that "save video" context menu appears for MSE video We should use media_flags to determine if a video can be saved. BUG= 637010 Committed: https://crrev.com/16006f8e310a6b0da0988b558f661003a8bd262e Review-Url: https://codereview.chromium.org/2239063004 Cr-Original-Commit-Position: refs/heads/master@{#411807} Cr-Commit-Position: refs/heads/master@{#412027} [modify] https://crrev.com/de0ea7338899803310109c27050fbbfef958f3f6/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java [modify] https://crrev.com/de0ea7338899803310109c27050fbbfef958f3f6/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java [modify] https://crrev.com/de0ea7338899803310109c27050fbbfef958f3f6/chrome/browser/ui/android/context_menu_helper.cc
,
Aug 16 2016
Verified in M54-54.0.2830.0 build |
||||
►
Sign in to add a comment |
||||
Comment 1 by tombergan@chromium.org
, Aug 11 2016