New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 637005 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 19
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-10-20
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Write browser tests to exercise OmniboxPopupViewMac::UpdatePopupAppearance code path.

Project Member Reported by erikc...@chromium.org, Aug 11 2016

Issue description

There were serious memory leaks there https://codereview.chromium.org/2233123003/#. Presumably, ASAN would have caught these bugs if the code was exercised.
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29

[To test this, I added an assert(false) right before -[OmniboxPopupTableController alloc], but all tests still passed].
 
*All browser_tests still passed.
Owner: pkasting@chromium.org
Status: Assigned (was: Untriaged)
Assigning to pkasting@ to find an owner. Right now, there is no browser test that tests the omnibox popup view. This should definitely be fixed.
Owner: sh...@chromium.org
I don't know who the Mac UI owners are at this point.  Long long ago, the Mac omnibox code was shess.

Comment 4 by groby@chromium.org, Dec 7 2016

Labels: -Pri-1 Pri-3
Owner: groby@chromium.org
As far as I can tell, this has tests:  https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm?rcl=0&l=56

The ASAN test hits those unit tests as well: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25185/steps/unit_tests/logs/stdio

(Why that doesn't catch the leak is not clear to me, though)

Cc: tommycli@chromium.org groby@chromium.org jdonnelly@chromium.org
Components: Tests>Missing
Owner: ----
Status: Available (was: Assigned)
Tommy or Justin, as people familiar with Omnibox Mac code, can you please check to see if you think there's something to this?

Based on the linked codereview above, this is beyond my current expertise in terms of Mac memory management.
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 20 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
NextAction: 2018-10-20
Status: Available (was: Untriaged)
Likely will be moot with MacViews.  Setting next action date to after MacViews may be on and stick.
The NextAction date has arrived: 2018-10-20

Comment 10 by rsesek@chromium.org, Jan 19 (4 days ago)

Status: WontFix (was: Available)
Obsolete with MacViews.

Sign in to add a comment