Issue metadata
Sign in to add a comment
|
Write browser tests to exercise OmniboxPopupViewMac::UpdatePopupAppearance code path. |
||||||||||||||||||||||
Issue descriptionThere were serious memory leaks there https://codereview.chromium.org/2233123003/#. Presumably, ASAN would have caught these bugs if the code was exercised. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29 [To test this, I added an assert(false) right before -[OmniboxPopupTableController alloc], but all tests still passed].
,
Aug 19 2016
Assigning to pkasting@ to find an owner. Right now, there is no browser test that tests the omnibox popup view. This should definitely be fixed.
,
Aug 20 2016
I don't know who the Mac UI owners are at this point. Long long ago, the Mac omnibox code was shess.
,
Dec 7 2016
As far as I can tell, this has tests: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm?rcl=0&l=56 The ASAN test hits those unit tests as well: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25185/steps/unit_tests/logs/stdio (Why that doesn't catch the leak is not clear to me, though)
,
Jun 19 2017
Tommy or Justin, as people familiar with Omnibox Mac code, can you please check to see if you think there's something to this?
,
Jun 19 2017
Based on the linked codereview above, this is beyond my current expertise in terms of Mac memory management.
,
Jun 20 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 20 2018
Likely will be moot with MacViews. Setting next action date to after MacViews may be on and stick.
,
Oct 20
The NextAction date has arrived: 2018-10-20
,
Jan 19
(4 days ago)
Obsolete with MacViews. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Aug 11 2016