New issue
Advanced search Search tips

Issue 636998 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

QUIC 34 occasionally fails to serialize packets

Project Member Reported by rch@chromium.org, Aug 11 2016

Issue description

QUIC v34 has a higher rate of FAILED_TO_SERIALIZE_PACKET errors. This appears to be a bug with how the packet number length is calculated.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46da07b554cec9b784fbc08bc0899d9d39fc8d30

commit 46da07b554cec9b784fbc08bc0899d9d39fc8d30
Author: rch <rch@chromium.org>
Date: Fri Aug 12 03:26:16 2016

Use LeastUnacked to calculate the packet number length instead of GetLeastPacketAwaitedByPeer.  Protected by default enabled FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG= 636998 

Review-Url: https://codereview.chromium.org/2237163002
Cr-Commit-Position: refs/heads/master@{#411541}

[modify] https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30/net/quic/core/quic_connection.cc
[modify] https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30/net/quic/core/quic_flags.cc
[modify] https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30/net/quic/core/quic_flags.h
[modify] https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30/net/quic/core/quic_sent_packet_manager.cc

Comment 2 by rch@chromium.org, Aug 15 2016

Labels: Merge-Request-53

Comment 3 by dimu@chromium.org, Aug 15 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Owner: rch@chromium.org
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 15 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f64bd662896f164cc9f4d3ea7eedf661cc0b9fb2

commit f64bd662896f164cc9f4d3ea7eedf661cc0b9fb2
Author: Ryan Hamilton <rch@chromium.org>
Date: Mon Aug 15 19:46:14 2016

[m53 merge] Use LeastUnacked to calculate the packet number length instead of GetLeastPacketAwaitedByPeer.  Protected by default enabled FLAGS_quic_least_unacked_packet_number_length.

Merge internal change: 128727157
Merge internal change: 129995365

BUG= 636998 
Committed: https://crrev.com/46da07b554cec9b784fbc08bc0899d9d39fc8d30
Cr-Commit-Position: refs/heads/master@{#411541}

TBR=zhongyi@chromium.org,

Review URL: https://codereview.chromium.org/2249783002 .

Cr-Commit-Position: refs/branch-heads/2785@{#606}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/f64bd662896f164cc9f4d3ea7eedf661cc0b9fb2/net/quic/quic_connection.cc
[modify] https://crrev.com/f64bd662896f164cc9f4d3ea7eedf661cc0b9fb2/net/quic/quic_flags.cc
[modify] https://crrev.com/f64bd662896f164cc9f4d3ea7eedf661cc0b9fb2/net/quic/quic_flags.h
[modify] https://crrev.com/f64bd662896f164cc9f4d3ea7eedf661cc0b9fb2/net/quic/quic_sent_packet_manager.cc

Comment 5 by rch@chromium.org, Aug 15 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment