New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636996 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Split -gline-tables-only out of is_asan=1 in favor of something like symbol_level=1.5

Project Member Reported by r...@chromium.org, Aug 11 2016

Issue description

When developers are reproducing an ASan report, it can be useful to have more than just line tables and backtraces. Because is_asan=1 implies -gline-tables-only, most of that debug info is not available out of the box. We set -gline-tables-only because it helps reduce binary size and build times, which is important for automated fuzzing.

We should try to make life easy for the average developer attempting to reproduce an ASan bug assigned to them by ClusterFuzz. I think that means they should get real debug information by default, or at least have some means to get it without touching build/config/sanitizers/BUILD.gn, which is what I just did.
 

Comment 1 by kcc@chromium.org, Aug 11 2016

Did you actually see a case where full debug info is that important? In the 5 years of asan existence I've never needed to debug an asan report with a debugger. 
(I am just curious and am not against this feature)

Comment 2 by r...@chromium.org, Aug 11 2016

I'm trying to debug  bug 636558 , and I wanted debug info to know:

- What is the layout of WTF::StringImpl. I looked at the class to figure this out myself, but debug info will do this for you.

- What is the real value of 'n'. I got this with printf debugging.

Maybe the default should stay as -gline-tables-only because it noticeably speeds up the build, which is often the first step to reproducing an asan report, but right now there is no way to get full debug info with asan in gn (or so I think).
Is the problem that is_asan=true is setting -gline-tables-only unconditionally and overriding symbol_level=2 (i.e., -g2)?

Because I think that's what would happen, and, if so, we should just fix that rather than add a fourth symbol level.
Labels: -Build-Tools-GN
Status: Available (was: Unconfirmed)
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 14 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold

Sign in to add a comment