New issue
Advanced search Search tips

Issue 636995 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

views_examples_with_content_exe on hidpi crashes with "Unable to load image"

Project Member Reported by ellyjo...@chromium.org, Aug 11 2016

Issue description

Running views_examples_with_content_exe on a retina macbook (or with --force-device-scale-factor=2):

[0810/144043:FATAL:resource_bundle.cc(176)] Check failed: false. Unable to load image with id 5968, scale=2
0   libbase.dylib                       0x000000010b2b2a8e _ZN4base5debug10StackTraceC2Ev + 30
1   libbase.dylib                       0x000000010b2b2af5 _ZN4base5debug10StackTraceC1Ev + 21
2   libbase.dylib                       0x000000010b336d50 _ZN7logging10LogMessageD2Ev + 80
3   libbase.dylib                       0x000000010b334905 _ZN7logging10LogMessageD1Ev + 21
4   libui_base.dylib                    0x000000011a8ac696 _ZN2ui14ResourceBundle25ResourceBundleImageSource16GetImageForScaleEf + 326
5   libgfx.dylib                        0x00000001181cfef2 _ZNK3gfx8internal16ImageSkiaStorage18FindRepresentationEfb + 2514
6   libgfx.dylib                        0x00000001181d361d _ZNK3gfx9ImageSkia17GetRepresentationEf + 269
7   libgfx.dylib                        0x00000001181dd85e _ZN3gfx16NineImagePainter5PaintEPNS_6CanvasERKNS_4RectEh + 542
8   libgfx.dylib                        0x00000001181dd63a _ZN3gfx16NineImagePainter5PaintEPNS_6CanvasERKNS_4RectE + 42
9   libviews.dylib                      0x000000011ba9dad5 _ZN5views12_GLOBAL__N_112ImagePainter5PaintEPN3gfx6CanvasERKNS2_4SizeE + 117
10  libviews.dylib                      0x000000011ba9b3a4 _ZN5views7Painter14PaintPainterAtEPN3gfx6CanvasEPS0_RKNS1_4RectE + 564
11  libviews.dylib                      0x000000011b9a02da _ZN5views12_GLOBAL__N_111PaintHelperEPNS_22LabelButtonAssetBorderEPN3gfx6CanvasEN2ui11NativeTheme5StateERKNS3_4RectERKNS7_11ExtraParamsE + 170
12  libviews.dylib                      0x000000011b9a01a4 _ZN5views22LabelButtonAssetBorder5PaintERKNS_4ViewEPN3gfx6CanvasE + 644
13  libviews.dylib                      0x000000011bab1adc _ZN5views4View13OnPaintBorderEPN3gfx6CanvasE + 588
14  libviews.dylib                      0x000000011bab1434 _ZN5views4View7OnPaintEPN3gfx6CanvasE + 356
15  libviews.dylib                      0x000000011b99c867 _ZN5views11LabelButton7OnPaintEPN3gfx6CanvasE + 39
16  libviews.dylib                      0x000000011baac503 _ZN5views4View5PaintERKN2ui12PaintContextE + 2627
17  libviews.dylib                      0x000000011bab128f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399
18  libviews.dylib                      0x000000011baac529 _ZN5views4View5PaintERKN2ui12PaintContextE + 2665
19  libviews.dylib                      0x000000011bab128f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399
20  libviews.dylib                      0x000000011baac529 _ZN5views4View5PaintERKN2ui12PaintContextE + 2665
21  libviews.dylib                      0x000000011bab128f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399
22  libviews.dylib                      0x000000011baac529 _ZN5views4View5PaintERKN2ui12PaintContextE + 2665
23  libviews.dylib                      0x000000011bab128f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399
24  libviews.dylib                      0x000000011baac529 _ZN5views4View5PaintERKN2ui12PaintContextE + 2665
25  libviews.dylib                      0x000000011bab128f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399
26  libviews.dylib                      0x000000011baac529 _ZN5views4View5PaintERKN2ui12PaintContextE + 2665
27  libviews.dylib                      0x000000011bab128f _ZN5views4View13PaintChildrenERKN2ui12PaintContextE + 399
28  libviews.dylib                      0x000000011baac529 _ZN5views4View5PaintERKN2ui12PaintContextE + 2665
29  libviews.dylib                      0x000000011bad833f _ZN5views6Widget19OnNativeWidgetPaintERKN2ui12PaintContextE + 63
30  libviews.dylib                      0x000000011b9799ce _ZN5views19BridgedNativeWidget12OnPaintLayerERKN2ui12PaintContextE + 334
31  libcompositor.dylib                 0x000000011be3f19f _ZN2ui5Layer26PaintContentsToDisplayListEN2cc18ContentLayerClient22PaintingControlSettingE + 703
32  libcompositor.dylib                 0x000000011be3f396 _ZThn8_N2ui5Layer26PaintContentsToDisplayListEN2cc18ContentLayerClient22PaintingControlSettingE + 38
33  libcc.dylib                         0x000000011ac25f37 _ZN2cc12PictureLayer6UpdateEv + 1255
34  libcc.dylib                         0x000000011aef50fe _ZN2cc9LayerTree12UpdateLayersERKNSt3__16vectorI13scoped_refptrINS_5LayerEENS1_9allocatorIS5_EEEEPb + 494
35  libcc.dylib                         0x000000011af0f4ef _ZN2cc13LayerTreeHost14DoUpdateLayersEPNS_5LayerE + 3503
36  libcc.dylib                         0x000000011af0e471 _ZN2cc13LayerTreeHost12UpdateLayersEv + 497
37  libcc.dylib                         0x000000011b05057b _ZN2cc17SingleThreadProxy16DoBeginMainFrameERKNS_14BeginFrameArgsE + 123
38  libcc.dylib                         0x000000011b051d92 _ZN2cc17SingleThreadProxy14BeginMainFrameERKNS_14BeginFrameArgsE + 930
39  libcc.dylib                         0x000000011b0543f3 _ZN4base8internal13FunctorTraitsIMN2cc17SingleThreadProxyEFvRKNS2_14BeginFrameArgsEEvE6InvokeIRKNS_7WeakPtrIS3_EEJS6_EEEvS8_OT_DpOT0_ + 147
40  libcc.dylib                         0x000000011b0542e9 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc17SingleThreadProxyEFvRKNS4_14BeginFrameArgsEERKNS_7WeakPtrIS5_EEJS8_EEEvOT_OT0_DpOT1_ + 105
41  libcc.dylib                         0x000000011b054279 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc17SingleThreadProxyEFvRKNS3_14BeginFrameArgsEEJNS_7WeakPtrIS4_EES5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_S5_EEEJLm0ELm1EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE + 105
42  libcc.dylib                         0x000000011b053ddc _ZN4base8internal7InvokerINS0_9BindStateIMN2cc17SingleThreadProxyEFvRKNS3_14BeginFrameArgsEEJNS_7WeakPtrIS4_EES5_EEEFvvEE3RunEPNS0_13BindStateBaseE + 44
43  libaccelerated_widget_mac.dylib     0x000000011e135bbe _ZNK4base8CallbackIFvvELNS_8internal8CopyModeE1EE3RunEv + 46
44  libaccelerated_widget_mac.dylib     0x000000011e134909 _ZN2ui12_GLOBAL__N_111WrappedTask3RunEv + 57
45  libaccelerated_widget_mac.dylib     0x000000011e13598d _ZN4base8internal13FunctorTraitsIMN2ui12_GLOBAL__N_111WrappedTaskEFvvEvE6InvokeIPS4_JEEEvS6_OT_DpOT0_ + 125
46  libaccelerated_widget_mac.dylib     0x000000011e1358bf _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN2ui12_GLOBAL__N_111WrappedTaskEFvvEJPS6_EEEvOT_DpOT0_ + 63
47  libaccelerated_widget_mac.dylib     0x000000011e13585b _ZN4base8internal7InvokerINS0_9BindStateIMN2ui12_GLOBAL__N_111WrappedTaskEFvvEJNS0_12OwnedWrapperIS5_EEEEEFvvEE7RunImplIRKS7_RKNSt3__15tupleIJS9_EEEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE + 91
48  libaccelerated_widget_mac.dylib     0x000000011e13540c _ZN4base8internal7InvokerINS0_9BindStateIMN2ui12_GLOBAL__N_111WrappedTaskEFvvEJNS0_12OwnedWrapperIS5_EEEEEFvvEE3RunEPNS0_13BindStateBaseE + 44
49  libbase.dylib                       0x000000010b27475e _ZNK4base8CallbackIFvvELNS_8internal8CopyModeE1EE3RunEv + 46
50  libbase.dylib                       0x000000010b2b4234 _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 676
51  libbase.dylib                       0x000000010b37bb0d _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 877
52  libbase.dylib                       0x000000010b37c0f4 _ZN4base11MessageLoop21DeferOrRunPendingTaskENS_11PendingTaskE + 68
53  libbase.dylib                       0x000000010b37cb6d _ZN4base11MessageLoop6DoWorkEv + 669
54  libbase.dylib                       0x000000010b38dcb8 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 104
55  libbase.dylib                       0x000000010b38dc3c ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
56  libbase.dylib                       0x000000010b339dca _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10
57  libbase.dylib                       0x000000010b38d1b5 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 101
58  CoreFoundation                      0x00007fff896b4881 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
59  CoreFoundation                      0x00007fff89693fbc __CFRunLoopDoSources0 + 556
60  CoreFoundation                      0x00007fff896934df __CFRunLoopRun + 927
61  CoreFoundation                      0x00007fff89692ed8 CFRunLoopRunSpecific + 296

This is probably because we're missing 2x resources in the views_examples_with_content_exe target.
 
Cc: tapted@chromium.org ellyjo...@chromium.org est...@chromium.org
 Issue 636025  has been merged into this issue.
Owner: tapted@chromium.org
I think https://codereview.chromium.org/2407733002 will fix this.

Comment 3 by tapted@chromium.org, Oct 10 2016

Better fix for just this problem: https://codereview.chromium.org/2406763002/
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16fe440227ce9e085117faa4c4b7af197de88602

commit 16fe440227ce9e085117faa4c4b7af197de88602
Author: tapted <tapted@chromium.org>
Date: Tue Oct 25 04:02:12 2016

In test code, allow any 100% data pack to provide fallbacks.

A test is allowed to request a 200% resource and fallback to a 100%
resource. Currently only the last-added 100% data pack provides
fallbacks, which may only be a small supplement.

Instead, scan through all 100% data packs. But only when
InitSharedInstanceWithPakPath() has invoked
ResourceBundle::LoadTestResources().

BUG= 636995 

Review-Url: https://codereview.chromium.org/2406763002
Cr-Commit-Position: refs/heads/master@{#427272}

[modify] https://crrev.com/16fe440227ce9e085117faa4c4b7af197de88602/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/16fe440227ce9e085117faa4c4b7af197de88602/ui/base/resource/resource_bundle.h

Comment 5 by tapted@chromium.org, Oct 25 2016

Status: Fixed (was: Started)

Sign in to add a comment