New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 429053
issue 631934



Sign in to add a comment

CopyTexSubImage3D should leave pixels untouched if the pixels are outside of the bound framebuffer

Project Member Reported by yunchao...@intel.com, Aug 11 2016

Issue description

CopyTexSubImage3D should initialize the pixels to 0 if the pixels are outside of the bound framebuffer. 

See the spec at https://www.khronos.org/registry/webgl/specs/latest/2.0/ for CopyTexSubImage3D: 

"For any pixel lying outside the frame buffer, all channels of the associated texel are initialized to 0"

We have not implemented this feature in Chromium yet. 

 
This patch can fix this issue: https://codereview.chromium.org/2234923002/. 

WebGL conformance test to expose this issue will be submitted too.

Comment 2 by kbr@chromium.org, Aug 12 2016

Summary: CopyTexSubImage3D should leave pixels untouched if the pixels are outside of the bound framebuffer (was: CopyTexSubImage3D should initialize the pixels to 0 if the pixels are outside of the bound framebuffer)
Thanks for tracking this down. This was an oversight; the rules were changed for CopyTexSubImage2D in the WebGL 1.0 spec some time ago, but never propagated to CopyTexSubImage3D in the WebGL 2.0 spec.

https://github.com/KhronosGroup/WebGL/pull/1965 will update the WebGL 2.0 spec. Changing the synopsis.

Comment 3 by kbr@chromium.org, Aug 12 2016

Labels: -Pri-3 Pri-2
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4547bc67a3ef3cb41208606885fb236e964f7b

commit 4f4547bc67a3ef3cb41208606885fb236e964f7b
Author: yunchao.he <yunchao.he@intel.com>
Date: Tue Aug 16 17:23:25 2016

[Command buffer] CopyTexSubImage3D: Copying pixels outside of framebuffer should be untouched

BUG= 636987 ,  631934 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2234923002
Cr-Commit-Position: refs/heads/master@{#412271}

[modify] https://crrev.com/4f4547bc67a3ef3cb41208606885fb236e964f7b/gpu/command_buffer/service/gles2_cmd_decoder.cc

Status: Fixed (was: Assigned)

Sign in to add a comment