New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636979 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Clicking on "Revert" button should post another message with the link to the revert

Project Member Reported by serg...@chromium.org, Aug 11 2016

Issue description

Clicking on "Revert" button should post another message with the link to the revert.
 

Comment 1 by rmis...@google.com, Aug 11 2016

Cc: rmis...@chromium.org
It does. It’s in the message list. Could you be more specific?
Status: Unconfirmed (was: Untriaged)
Labels: Needs-Feedback
https://chromium-review.googlesource.com/c/366771/ was reverted, yet no message is posted. If new CLs do have that message, please close this as WontFix.
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 20 2016

Labels: -Needs-Feedback Needs-Review
Owner: ranjitkan@chromium.org
Thank you for providing more feedback. Adding requester "ranjitkan@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Blink>Forms>Button

Comment 8 by rmis...@google.com, Aug 22 2016

Components: -Blink>Forms>Button Infra>Codereview>Gerrit
Owner: ----
Status: Available (was: Unconfirmed)
Unless I am missing something it looks like PG does not post a link to the reverted CL in the original CL like Rietveld does. Eg: https://codereview.chromium.org/2255283002/#msg33
This is useful for creating an audit trail.

Andy, is it possible to create a Gerrit message via PG? I can take this one if you do not mind pointing me in the right direction.

Comment 9 by rmis...@google.com, Aug 23 2016

Cc: andyb...@chromium.org
Just realized I never added Andy to the issue for the question in https://bugs.chromium.org/p/chromium/issues/detail?id=636979#c8
It does. As the latest message in the message list it linked to the newly created change.
Labels: Pri-2

Comment 12 by rmis...@google.com, Aug 31 2016

Status: WontFix (was: Available)
Tested it out today and yes a link is added to the newly created change. Eg:
https://skia-review.googlesource.com/c/2220/#message-7405730f40e6592184a337c9143c17aadd89fe7a

There is a bug though for non chromium-review instances, the link there appears points to chromium-review (event for skia-review). Marking this as WontFix and filed https://bugs.chromium.org/p/gerrit/issues/detail?id=4471

Sign in to add a comment