New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636976 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 436283



Sign in to add a comment

Canary crash on requestDevice from chrome extension (was working on previous canary release)

Reported by ogil...@gmail.com, Aug 11 2016

Issue description

Chrome Version       : Version 54.0.2826.0 canary (64-bit) (Mac)
URLs  : Chrome extension
Other browsers tested:
have tested this issue:
     Chromium OS : OK
     Canary OS : FAIL

What steps will reproduce the problem?
(1) requestDevice with service 00001808-0000-1000-8000-00805f9b34fb
(2) Canary crashes immediatly, impossible to see any log

Same operations in chromium os with same extension works fine. Using BLE via chrome extension, multiple times, I've never seen the device popup chooser.
BLE connexions with web bluetooth samples in Canary works fine.
This extension and connect method was working on previous canary release (number ???)

What is the expected result?
My Nexus 6 is find and connection to gatt server is initiated

What happens instead?
Canary crashes

Please provide any additional information below. Attach a screenshot if
possible.

Crash report attach below

Olivier


 
crashReport.txt
89.4 KB View Download

Comment 1 by ortuno@chromium.org, Aug 11 2016

Can you see the crash in chrome://crashes/ ?

Comment 2 by ortuno@chromium.org, Aug 11 2016

And if so could you paste the crash id here?

Comment 3 by ortuno@chromium.org, Aug 11 2016

Blocking: 436283
Cc: juncai@chromium.org

Comment 4 by ogil...@gmail.com, Aug 11 2016

Here is one of the crash id :


      b56d09a8-aaac-41ec-9a58-174ad932ff2b

and the server id :


      3c9c144100000000



Le 11/08/2016 à 17:28, ort… via monorail a écrit :

Comment 5 by ortuno@chromium.org, Aug 11 2016

Cc: -juncai@chromium.org
Labels: -Pri-3 Pri-1
Status: Started (was: Unconfirmed)
Ah I see what the problem is:

https://chromium.googlesource.com/chromium/src/+/master/content/browser/bluetooth/bluetooth_device_chooser_controller.cc#312

That line is not returning.
Cc: juncai@chromium.org
Labels: OS-Chrome
I've just reproduced this issue and I confirm it crashes when calling navigator.bluetooth.requestDevice from a Chrome Extension background page and a Chrome Extension popup page (browserAction).

However it doesn't crash from a chrome-extension://<extension_id>/page.html tab.

@juncai I understand why a background page would not trigger Bluetooth chooser but why not from a popup page?

Comment 7 by ortuno@chromium.org, Aug 12 2016

Owner: ortuno@chromium.org
I had a fix yesterday but didn't realize it didn't land. http://crrev.com/2238973002
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b38275d302118a3c5d8437314e08481c8a167d32

commit b38275d302118a3c5d8437314e08481c8a167d32
Author: ortuno <ortuno@chromium.org>
Date: Fri Aug 12 15:55:52 2016

bluetooth: Add missing return when bluetooth not supported.

This was causing a null pointer derefence in line 317.

BUG= 636976 

Review-Url: https://codereview.chromium.org/2238973002
Cr-Commit-Position: refs/heads/master@{#411663}

[modify] https://crrev.com/b38275d302118a3c5d8437314e08481c8a167d32/content/browser/bluetooth/bluetooth_device_chooser_controller.cc

Comment 9 by ortuno@chromium.org, Aug 12 2016

Status: Fixed (was: Started)

Comment 10 by ogil...@gmail.com, Aug 14 2016

Hi all,
As I can't establish a ble connexion from a background page, is there a 
possibility to maintain a ble connexion active (established from a tab) 
if I close the tab ?
In other words, can I pass the connected device object from my extension 
tab to my long lived background chrome extension ?

Thanks
Olivier

Le 12/08/2016 à 18:00, ort… via monorail a écrit :
Labels: VerifyIn-54
Hi Olivier,

You can't yet do that.
See https://github.com/WebBluetoothCG/web-bluetooth/issues/57#issuecomment-208632357 for some background.

What is your use case?
Labels: VerifyIn-55

Comment 14 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 15 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 16 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 17 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 18 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 20 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment