New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636964 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 598405



Sign in to add a comment

iOS test execution on Swarming are referring to scripts in /b/build_internal/scripts/slave-internal/bling/

Project Member Reported by mar...@chromium.org, Aug 11 2016

Issue description

In 2015 as a way to "quick start" the iOS porting to Swarming, we agreed, as a short term measure, to keep a buildbot slave checkout on the iOS Swarming bots.

AIs:
- Change the iOS recipes to map all the necessary scripts in the .isolate files upfront so they stop running commands as an absolute path referring to '/b/build_internal/...'.
- Delete the buildbot slave checkouts from the Swarming bots on touch-swarming.appspot.com

This is bad because right now, a user doing changes to the recipes or the test scripts doesn't know which version of the script was used to do the test execution. The task is at the mercy of the bot's state, which may or may not have an up-to-date /b/build_internal checkout.
 
Cc: baxley@chromium.org huangml@chromium.org rohitrao@chromium.org

Comment 2 by smut@chromium.org, Aug 11 2016

Blockedon: 598405
I'm working on Swarming for upstream iOS bots, which do isolate all necessary scripts. Once it's done I'll have downstream bots just use that.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: to-review

Comment 5 by s...@google.com, Nov 9 2016

Status: Fixed (was: Assigned)
Are /b/build_internal deleted from the Swarming bots.

Comment 7 by maruel@google.com, Nov 23 2016

My previous was actually a question. I've spot checked build10-m7 and it still have a build slave checkout. This should be cleaned up but I don't want to do it in case it breaks anything.

In practice, you can do it via bot_config; copy https://chrome-internal.googlesource.com/infra/infra_internal.git/+/master/services/swarming/bot_config_public.py#187
to
https://chrome-internal.googlesource.com/infra/infra_internal.git/+/master/services/swarming/bot_config_private.py
to be called from on_bot_startup() and that will take care of the problem without having to ssh into each bot.

Comment 8 by s...@google.com, Nov 23 2016

I think that removing the directories on_bot_startup might be overkill. For now I've triggered tasks fleetwide to remove /b/.gclient, /b/.gclient_entries, /b/build, /b/build_internal, /b/depot_tools, and /b/internal.DEPS.

Sign in to add a comment