TabsTest flaking in Jelly Bean Tester |
|||||
Issue descriptionThe latest runs of chrome_public_test_apk have all failed due to different failing tests in org.chromium.chrome.browser.TabsTest # Jelly Bean Tester: 5454 -> 5445 # ----F-F--- TabsTest#testCloseLastTabFromMain --F------- TabsTest#testIncognitoTabsNotRestoredAfterSwipe ---F------ TabsTest#testNewTabButton -F-------- TabsTest#testOrientationChangeCausesLiveTabReflowInNormalView F--------- TabsTest#testOrientationChangeCausesLiveTabReflowInTabSwitcher For example from the most recent build, the short bit of output says: I 2442.768s run_tests_on_device(01cd2ea51a1ba2b6) detected failure in org.chromium.chrome.browser.TabsTest#testOrientationChangeCausesLiveTabReflowInTabSwitcher. raw output: I 2442.768s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS: id=InstrumentationTestRunner I 2442.769s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS: current=1 I 2442.769s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS: class=org.chromium.chrome.browser.TabsTest I 2442.769s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS: stream= I 2442.769s run_tests_on_device(01cd2ea51a1ba2b6) org.chromium.chrome.browser.TabsTest: I 2442.769s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS: numtests=1 I 2442.769s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS: test=testOrientationChangeCausesLiveTabReflowInTabSwitcher I 2442.770s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_STATUS_CODE: 1 I 2442.770s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_RESULT: shortMsg=Native crash I 2442.770s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_RESULT: longMsg=Native crash: Segmentation fault I 2442.770s run_tests_on_device(01cd2ea51a1ba2b6) INSTRUMENTATION_CODE: 0 https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5454/steps/chrome_public_test_apk/logs/stdio
,
Aug 11 2016
+ianwen, +bauerb, you've been working recently on NewTabPage, maybe you can help with these?
,
Aug 11 2016
Ian, all of these new flakes are after your CL to reland the infobar change, which happened in Jelly Bean build 5448: https://build.chromium.org/p/chromium.android/builders/Jelly%20Bean%20Tester/builds/5448 Example stack traces Java stderr from crashing pid (may identify underlying Java exception): java.lang.NoSuchMethodError: android.view.View.isAttachedToWindow at org.chromium.chrome.browser.ntp.NewTabPage.destroy(NewTabPage.java:767) at org.chromium.chrome.browser.tab.Tab.destroyNativePageInternal(Tab.java:2353) at org.chromium.chrome.browser.tab.Tab.showRenderedPage(Tab.java:1421) at org.chromium.chrome.browser.tab.Tab.handleDidCommitProvisonalLoadForFrame(Tab.java:1932) at org.chromium.chrome.browser.tab.TabWebContentsObserver.didCommitProvisionalLoadForFrame(TabWebContentsObserver.java:233) at org.chromium.content.browser.webcontents.WebContentsObserverProxy.didCommitProvisionalLoadForFrame(WebContentsObserverProxy.java:174) at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:39) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:137) at android.app.ActivityThread.main(ActivityThread.java:5103) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:525) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) at dalvik.system.NativeStart.main(Native Method) Java stderr from crashing pid (may identify underlying Java exception): java.lang.NoSuchMethodError: android.view.View.isAttachedToWindow at org.chromium.chrome.browser.ntp.IncognitoNewTabPage.destroy(IncognitoNewTabPage.java:86) at org.chromium.chrome.browser.tab.Tab.destroyNativePageInternal(Tab.java:2353) at org.chromium.chrome.browser.tab.Tab.destroy(Tab.java:2029) at org.chromium.chrome.browser.tabmodel.TabModelImpl.finalizeTabClosure(TabModelImpl.java:589) at org.chromium.chrome.browser.tabmodel.TabModelImpl.closeTab(TabModelImpl.java:369) at org.chromium.chrome.browser.tabmodel.TabModelImpl.closeTab(TabModelImpl.java:340) at org.chromium.chrome.browser.tabmodel.OffTheRecordTabModel.closeTab(OffTheRecordTabModel.java:120) at org.chromium.chrome.browser.tabmodel.TabModelUtils.closeTabById(TabModelUtils.java:48) at org.chromium.chrome.browser.compositor.layouts.phone.StackLayout.uiDoneClosingTab(StackLayout.java:444) at org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack.finishAnimation(Stack.java:585) at org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack.finishAnimationsIfDone(Stack.java:736) at org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack.onUpdateCompositorAnimations(Stack.java:719) at org.chromium.chrome.browser.compositor.layouts.phone.StackLayout.onUpdateAnimation(StackLayout.java:366) at org.chromium.chrome.browser.compositor.layouts.Layout.onUpdate(Layout.java:318) at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate(LayoutManager.java:225) at org.chromium.chrome.browser.compositor.layouts.LayoutManager.onUpdate(LayoutManager.java:210) at org.chromium.chrome.browser.compositor.CompositorViewHolder.onCompositorLayout(CompositorViewHolder.java:534) at org.chromium.chrome.browser.compositor.CompositorView.onCompositorLayout(CompositorView.java:245) at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:39) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:137) at android.app.ActivityThread.main(ActivityThread.java:5103) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:525) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) at dalvik.system.NativeStart.main(Native Method)
,
Aug 11 2016
It looks like View#isAttachedToWindow() was added in API level 19. These should be ViewCompat's, though, right?
,
Aug 11 2016
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e00bc4eabb303887156d21d9193e8f5993edb81 commit 5e00bc4eabb303887156d21d9193e8f5993edb81 Author: ianwen <ianwen@chromium.org> Date: Thu Aug 11 21:13:36 2016 Fix a test failure on jellybean devices There is test regression on Jellybean devices due to https://codereview.chromium.org/2239453002. BUG= 636939 Review-Url: https://codereview.chromium.org/2237143002 Cr-Commit-Position: refs/heads/master@{#411420} [modify] https://crrev.com/5e00bc4eabb303887156d21d9193e8f5993edb81/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java [modify] https://crrev.com/5e00bc4eabb303887156d21d9193e8f5993edb81/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
,
Aug 11 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by perezju@chromium.org
, Aug 11 2016