New issue
Advanced search Search tips

Issue 636934 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 609258



Sign in to add a comment

Fix ManifestUpgradeDetector logic when manifest has an icon URL but the icon URL does not point to an image

Project Member Reported by pkotw...@chromium.org, Aug 11 2016

Issue description

Fix ManifestUpgradeDetector logic when manifest has an icon URL but the icon URL does not point to an image

In particular, we need to make ManifestUpgradeDetector take into account:

void AddToHomescreenDataFetcher::OnManifestIconFetched(const GURL& icon_url,
                                                       const SkBitmap& icon) {
  if (icon.drawsNothing()) {
    FetchFavicon();
    return;
  }
  shortcut_info_.icon_url = icon_url;
  NotifyObserver(icon);
}
 
Status: WontFix (was: Untriaged)
I am dealing with this as part of https://codereview.chromium.org/2331773002/
Marking as WontFix

Sign in to add a comment