New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636880 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.8%-16.2% regression in startup.warm.blank_page at 410663:410726

Project Member Reported by pmeenan@chromium.org, Aug 11 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=636880

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgtvX7uAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg9uy3sAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg9uqPqwoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win8-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 11 2016

Cc: roc...@chromium.org
Owner: roc...@chromium.org

=== Auto-CCing suspected CL author rockot@chromium.org ===

Hi rockot@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Eliminate kMojoChannelToken usage for render processes
Author  : rockot
Commit description:
  
Changes RenderProcessHostImpl to connect its IPC Channel
by requesting a nominal IPC::mojom::ChannelBootstrap
interface from its shell::Connection to the render process.

Changes ChildThreadImpl to support binding such requests
by fusing them to its local IPC Channel if the (now deprecated)
kMojoChannelToken was not provided.

BUG= 623396 
R=ben@chromium.org

Committed: https://crrev.com/7a7f8f7e6977500d09270ff9d9b3817dda5e5b8a
Review-Url: https://codereview.chromium.org/2201183005
Cr-Original-Commit-Position: refs/heads/master@{#410656}
Cr-Commit-Position: refs/heads/master@{#410699}
Commit  : ff1b853cb6bfc3d5402fc970b2d856cbe73418cc
Date    : Tue Aug 09 16:38:39 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev   N  Good?
chromium@410667  130.211  0.3589    5  good
chromium@410690  131.032  0.94488   5  good
chromium@410696  130.989  0.549994  5  good
chromium@410698  132.358  2.06018   5  good
chromium@410699  192.821  10.0875   5  bad    <--
chromium@410700  160.989  13.9507   5  bad
chromium@410713  190.737  12.1531   5  bad

Bisect job ran on: winx64intel_perf_bisect
Bug ID: 636880

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests startup.warm.blank_page
Test Metric: first_main_frame_load_time/first_main_frame_load_time
Relative Change: 46.48%
Score: 98.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1103
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9004621268637302160


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5866310051823616

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Perf sheriff ping: reminder to follow up on possible performance issues
rockot, this does seem to be your change. Can you please investigate?
rockot@, seems like your mojo IPC project trigger a lot of regression. Can you please investigate?
Status: Fixed (was: Assigned)
It looks like the graphs here all recovered around r413197, which reduces the number of allocs/frees per message. Please reopen if you think I'm misinterpreting the data.

Sign in to add a comment