New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636835 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

"async-callstack-async-await2" test exceeds timelimits

Project Member Reported by kolos@chromium.org, Aug 11 2016

Issue description

Cc: littledan@chromium.org caitpott...@gmail.com pfeldman@chromium.org
 Issue 636837  has been merged into this issue.
Please see 636837 for more details

Comment 3 by samli@chromium.org, Aug 12 2016

Components: Platform>DevTools
Labels: -Sheriff-Chromium
Status: Available (was: Assigned)

Comment 5 by ca...@igalia.com, Aug 16 2016

It's a bit worrying that the windows debug tests are so flaky, compared with other platforms.

I can send a test expectations fix in a moment.

Comment 6 by a...@chromium.org, Aug 16 2016

FYI, we were seeing await3 flake on linux, which is rather new.

Comment 7 by ca...@igalia.com, Aug 16 2016

"TIMEOUT TIMEOUT PASS" doesn't look "as bad" as the intermittent failures on win7 debug, but please comment on https://codereview.chromium.org/2247843004 so I can adjust expectations more if needed
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e7ba6882b7add094bf0843187856baabc7d9f6

commit 81e7ba6882b7add094bf0843187856baabc7d9f6
Author: Bret Sepulveda <bsep@chromium.org>
Date: Tue Aug 16 22:24:53 2016

Disable various async-callback-async-awaits.

Mark async-callback-async-await2 timeout on Linux Debug and
async-callback-async-await3 timeout on Win7 Debug.

TBR=pfeldman
BUG= 636835 

Review URL: https://codereview.chromium.org/2248193002 .

Cr-Commit-Position: refs/heads/master@{#412359}

[modify] https://crrev.com/81e7ba6882b7add094bf0843187856baabc7d9f6/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by bsep@chromium.org, Aug 16 2016

await2 (linux) and await3 (win) were timing out reliably on Debug.
Cc: alex...@chromium.org
 Issue 640243  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339

commit c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339
Author: lukasza <lukasza@chromium.org>
Date: Tue Aug 23 18:12:20 2016

Skip virtual equivalent of async-callstack-async-await*.html layout tests.

Non-virtual async-callstack-async-await*.html tests have been disabled
in r409884, but the tests have been flakily running and timing out in
the virtual test suites:

- Site Isolation Win:
  https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15853

- WebKit Mac10.11 (dbg):
  https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fasyncawait%2Finspector%2Fsources%2Fdebugger-async%2Fasync-await%2Fasync-callstack-async-await2.html

Based, on the above, this CL is broadening the test expectations for
virtual/asyncawait/.../async-callstack-async-await[23].html so that:

- They cover non-Debug builds (since Site Isolation Win tests Release build)

- They cover all platforms (since these tests are also flaky on Mac10.11)

BUG= 636835 ,  621515 
NOTRY=true

Review-Url: https://codereview.chromium.org/2276583002
Cr-Commit-Position: refs/heads/master@{#413786}

[modify] https://crrev.com/c21f0eed0a07d8542838f4d5aaeb6d7fa0b2c339/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eabc22ef76859401193b8ff870b5a4b429661f9

commit 4eabc22ef76859401193b8ff870b5a4b429661f9
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Aug 23 19:17:31 2016

[DevTools] Masrk virtual/asyncawait/inspector as slow

Mark virtual/asyncawait/inspector/sources/debugger-async/ as SLOW.
I'll mark it as timeout if it won't help.

BUG= 636835 ,  621515 
NOTRY=true
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2275643002
Cr-Commit-Position: refs/heads/master@{#413811}

[modify] https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/4eabc22ef76859401193b8ff870b5a4b429661f9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by sheriffbot@chromium.org, Aug 24 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)
based on test-results there is no new flaky result.

Sign in to add a comment