Suspected CLs

Change #11625

Changed by	tapted@chromium.org
Changed at	Wed 10 Aug 2016 23:06:20
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	a3d3da13da743ee2b63e5e0fd45d899e45ce2979
Comments

Mac: Share kScrollbarPixelsPerCocoaTick between ui:: and blink:: events

Currently scrolling in MacViews with a "real" mouse wheel is too fast. A
multiplier is applied that maps the values used for
kCGScrollEventUnitLine to (effectively) kCGScrollEventUnitPixel, and the
one used for MacViews was too big. Share the constant that content::
uses by moving it to ui/events/cocoa/cocoa_event_utils.h

Add a test to ensure the event types agree. Problem: the initializers on
NSEvent for creating test events are too limited. We also want to beef
up testing of scroll event streams for elastic scrolling and whatnot, so
move the stuff in events_mac_unittest.mm to cocoa_test_event_utils:: for
creating test scroll events.

BUG=615948

Committed: https://crrev.com/315a111b6cdd928cbd0862dd97f5a98482dd0261
Review-Url: https://codereview.chromium.org/2226933004
Cr-Original-Commit-Position: refs/heads/master@{#411216}
Cr-Commit-Position: refs/heads/master@{#411275}
Changed files

content/browser/renderer_host/input/web_input_event_builders_mac.mm
content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm
ui/events/cocoa/cocoa_event_utils.h
ui/events/cocoa/events_mac.mm
ui/events/cocoa/events_mac_unittest.mm
ui/events/test/cocoa_test_event_utils.h
ui/events/test/cocoa_test_event_utils.mm
Properties

Git_revision	a3d3da13da743ee2b63e5e0fd45d899e45ce2979
Change #11626

Changed by	dbeam@chromium.org
Changed at	Wed 10 Aug 2016 23:11:55
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	a620af406275d8e5bf37832661f773ec60f3802a
Comments

MD Settings: implement metrics reporting checkbox on desktop

BUG= 614265 , 632443 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2233443002
Cr-Commit-Position: refs/heads/master@{#411276}
Changed files

chrome/browser/metrics/chrome_metrics_service_accessor.h
chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
chrome/browser/resources/settings/privacy_page/privacy_page.html
chrome/browser/resources/settings/privacy_page/privacy_page.js
chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
chrome/browser/resources/settings/settings_resources.grd
chrome/browser/ui/webui/settings/md_settings_ui.cc
chrome/browser/ui/webui/settings/metrics_reporting_handler.cc
chrome/browser/ui/webui/settings/metrics_reporting_handler.h
chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
chrome/chrome_browser_ui.gypi
chrome/chrome_tests_unit.gypi
chrome/test/data/webui/settings/cr_settings_browsertest.js
chrome/test/data/webui/settings/metrics_reporting_tests.js
ui/webui/resources/cr_elements/policy/cr_policy_indicator.css
ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
ui/webui/resources/cr_elements/policy/cr_policy_vars_css.html
ui/webui/resources/cr_elements_resources.grdp
Properties

Git_revision	a620af406275d8e5bf37832661f773ec60f3802a
Change #11627

Changed by	sdefresne@chromium.org
Changed at	Wed 10 Aug 2016 23:14:09
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	95e03563d71116d3a85a5108509e7eb87cb04cf3
Comments

Enable code signature for Cronet.framework.

The underlying issue that cause the code signature to fail for
Cronet.framework was fixed with http://crrev.com/2233663002/ &
http://crrev.com/2231723002/.

BUG=None

Review-Url: https://codereview.chromium.org/2238583002
Cr-Commit-Position: refs/heads/master@{#411277}
Changed files

components/cronet/ios/BUILD.gn
Properties

Git_revision	95e03563d71116d3a85a5108509e7eb87cb04cf3
Change #11625

Changed by	tapted@chromium.org
Changed at	Wed 10 Aug 2016 23:06:20
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	a3d3da13da743ee2b63e5e0fd45d899e45ce2979
Comments

Mac: Share kScrollbarPixelsPerCocoaTick between ui:: and blink:: events

Currently scrolling in MacViews with a "real" mouse wheel is too fast. A
multiplier is applied that maps the values used for
kCGScrollEventUnitLine to (effectively) kCGScrollEventUnitPixel, and the
one used for MacViews was too big. Share the constant that content::
uses by moving it to ui/events/cocoa/cocoa_event_utils.h

Add a test to ensure the event types agree. Problem: the initializers on
NSEvent for creating test events are too limited. We also want to beef
up testing of scroll event streams for elastic scrolling and whatnot, so
move the stuff in events_mac_unittest.mm to cocoa_test_event_utils:: for
creating test scroll events.

BUG=615948

Committed: https://crrev.com/315a111b6cdd928cbd0862dd97f5a98482dd0261
Review-Url: https://codereview.chromium.org/2226933004
Cr-Original-Commit-Position: refs/heads/master@{#411216}
Cr-Commit-Position: refs/heads/master@{#411275}
Changed files

content/browser/renderer_host/input/web_input_event_builders_mac.mm
content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm
ui/events/cocoa/cocoa_event_utils.h
ui/events/cocoa/events_mac.mm
ui/events/cocoa/events_mac_unittest.mm
ui/events/test/cocoa_test_event_utils.h
ui/events/test/cocoa_test_event_utils.mm
Properties

Git_revision	a3d3da13da743ee2b63e5e0fd45d899e45ce2979
Change #11626

Changed by	dbeam@chromium.org
Changed at	Wed 10 Aug 2016 23:11:55
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	a620af406275d8e5bf37832661f773ec60f3802a
Comments

MD Settings: implement metrics reporting checkbox on desktop

BUG= 614265 , 632443 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2233443002
Cr-Commit-Position: refs/heads/master@{#411276}
Changed files

chrome/browser/metrics/chrome_metrics_service_accessor.h
chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
chrome/browser/resources/settings/privacy_page/privacy_page.html
chrome/browser/resources/settings/privacy_page/privacy_page.js
chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
chrome/browser/resources/settings/settings_resources.grd
chrome/browser/ui/webui/settings/md_settings_ui.cc
chrome/browser/ui/webui/settings/metrics_reporting_handler.cc
chrome/browser/ui/webui/settings/metrics_reporting_handler.h
chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
chrome/chrome_browser_ui.gypi
chrome/chrome_tests_unit.gypi
chrome/test/data/webui/settings/cr_settings_browsertest.js
chrome/test/data/webui/settings/metrics_reporting_tests.js
ui/webui/resources/cr_elements/policy/cr_policy_indicator.css
ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
ui/webui/resources/cr_elements/policy/cr_policy_vars_css.html
ui/webui/resources/cr_elements_resources.grdp
Properties

Git_revision	a620af406275d8e5bf37832661f773ec60f3802a
Change #11627

Changed by	sdefresne@chromium.org
Changed at	Wed 10 Aug 2016 23:14:09
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	95e03563d71116d3a85a5108509e7eb87cb04cf3
Comments

Enable code signature for Cronet.framework.

The underlying issue that cause the code signature to fail for
Cronet.framework was fixed with http://crrev.com/2233663002/ &
http://crrev.com/2231723002/.

BUG=None

Review-Url: https://codereview.chromium.org/2238583002
Cr-Commit-Position: refs/heads/master@{#411277}
Changed files

components/cronet/ios/BUILD.gn
Properties

Git_revision	95e03563d71116d3a85a5108509e7eb87cb04cf3

My CL is iOS only change, so removing self from cc as this test is not run on iOS.

Perhaps the Idle Wakeups threshold used in the test is still too high.
The test does series of sleeps in JavaScript with 1 ms interval aiming for reaching at least 100 Idle Wakeups per second.

Looking at the failed test instances I see the following numbers: 67, 35, 45, 66, 77, 75. This is ASAN build running tests in swarming mode so that is what makes the test slow and lowers the number of context switches.

I could try lowering the threshold to something like 30. I'll investigate if there is anything else I could do.

This is no longer failing on https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29?numbuilds=200

 Issue 639939  has been merged into this issue.

Changing this to untriaged because I won't be able to work on this.
FYI, the test is currently disabled on MACOSX.

[mac triage]

shrike@ can you please handle or triage?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d94308f43511e4d3098978dcdb3e854d1a713832

commit d94308f43511e4d3098978dcdb3e854d1a713832
Author: Jayson Adams <shrike@chromium.org>
Date: Sat Jan 20 00:52:29 2018

[Mac] Reenable TaskManagerBrowserTest.IdleWakeup

The TaskManagerBrowserTest.IdleWakeup browser test was disabled for
flakiness. The issue is this test, written with Chrome Win in mind,
was expected to generate 1000s of idle wakes, but at least 100. However
on the Mac the idle wake count is lower on certain releases (e.g.
between 65 and 81 on macOS 10.12). This cl reenables the test on macOS
and lowers the expected wake count.

Bug:  636823 
Change-Id: Idba223012e2e868c39bf2b27d02c167e3d3dbad2
Reviewed-on: https://chromium-review.googlesource.com/876920
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530700}
[modify] https://crrev.com/d94308f43511e4d3098978dcdb3e854d1a713832/chrome/browser/task_manager/task_manager_browsertest.cc