New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 636816 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Blank chrome://md-settings/syncSetup is seen on reloading the page.

Project Member Reported by bj00129...@techmahindra.com, Aug 11 2016

Issue description

Version: 54.0.2826.0 Dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Signin to chrome with valid credentials>>Navigate to chrome://md-settings/syncSetup>>Now hit Ctrl+R or F5 and Observe sync setup page is seen blank.

Expected: Sync setup page should not get blank.
Actual:Instead sync setup page is seen blank.

This is Regression issue broken in M-54. Will soon provide bisect info.
Attaching screen-cast for reference.
 
Actual_Syncsetup.ogv
739 KB View Download
Labels: OS-Mac
Able to reproduce the issue on Mac 10.11.6 using 54.0.2826.0.
Labels: -Needs-Bisect hasbisect ReleaseBlock-Stable
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to do tool bisect as issue is seen only after signing into chrome which can't be done in chromium builds.

Manual Bisect info:
Good build:54.0.2824.0 Dev
Bad build:54.0.2825.0 Dev

CHANGE-LOG:
https://chromium.googlesource.com/chromium/src/+log/54.0.2824.0..54.0.2825.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2229443003 from change-log.

@dpapad: Please help in re-assigning if it is not related to your change.

Adding Stable blocker label as it is recent regression.

Comment 3 by dpa...@chromium.org, Aug 11 2016

Labels: -ReleaseBlock-Stable

Comment 4 by dpa...@chromium.org, Aug 11 2016

Cc: michae...@chromium.org
After my change at https://codereview.chromium.org/2229443003, the dom-if <template name="sync"> node is inside another dom-if template. When visiting the URL directly, the following happens,
 - Line at [1] executes first, returning early.
 - Line at [2] executes after, returns true, but it is too late at this point, no-one is stamping the inner template.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/settings_page/settings_animated_pages.js?l=142
[2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/people_page.js?q=people_page.js&l=299

I have an alternative fix which seems to satisfy both searching and direct navigation to the advanced sync settings page at https://codereview.chromium.org/2235323002.

Comment 5 by dpa...@chromium.org, Aug 11 2016

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a629fcba45a437827cfc2ac36fba9ad97b6bb3f1

commit a629fcba45a437827cfc2ac36fba9ad97b6bb3f1
Author: dpapad <dpapad@chromium.org>
Date: Fri Aug 12 00:01:07 2016

MD Settings: Fix advanced sync page reload.

A blank page was shown on direct navigation after
https://codereview.chromium.org/2229443003. It turns out that wrapping a
settings-subpage's dom-if within another dom-if is problematic, because the
settings-animated-pages ensureSubpageInstance_() executes before the outer
dom-if has been evaluated to true, leaving the page blank.

Fixed by removing the nested dom-if and using the no-search attribute instead,
to instruct the searching algorithm when to ignore the "advanced sync settings"
page.

BUG= 636816 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2235323002
Cr-Commit-Position: refs/heads/master@{#411459}

[modify] https://crrev.com/a629fcba45a437827cfc2ac36fba9ad97b6bb3f1/chrome/browser/resources/settings/people_page/people_page.html

Comment 7 by dpa...@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
Labels: TE-Verified-54.0.2830.0 TE-Verified-M54
Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 54.0.2830.0.Sync setup page is not blank after CTRL+R or F5.
Please find attached screencast.

Marking it as TE-Verified.

636816.mp4
499 KB View Download

Sign in to add a comment