top_10_mobile_memory is occasionally failing on Windows |
||||
Issue descriptionThis test fails maybe one out of 20 builds. Example failure: https://build.chromium.org/p/chromium.perf/builders/Win%20Zenbook%20Perf%20%282%29/builds/2819/steps/top_10_mobile_memory/logs/stdio/text Error when collecting Chrome tracing on devtools at port 61825: Traceback (most recent call last): File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\platform\tracing_agent\chrome_tracing_agent.py", line 228, in CollectAgentTraceData client.CollectChromeTracingData(trace_data_builder) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\devtools_client_backend.py", line 369, in CollectChromeTracingData self._tracing_backend.CollectTraceData(trace_data_builder, timeout) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\tracing_backend.py", line 227, in CollectTraceData self._CollectTracingData(trace_data_builder, timeout) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\tracing_backend.py", line 248, in _CollectTracingData self._inspector_websocket.DispatchNotifications(timeout) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_websocket.py", line 134, in DispatchNotifications self._Receive(timeout) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_websocket.py", line 168, in _Receive self._HandleAsyncResponse(result) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\inspector_websocket.py", line 184, in _HandleAsyncResponse callback(result) File "C:\b\c\b\Win_Zenbook_Perf__2_\src\third_party\catapult\telemetry\telemetry\internal\backends\chrome_inspector\tracing_backend.py", line 80, in _GotChunkFromStream trace_string = ''.join(self._data) MemoryError (Please take a moment to appreciate the irony that this is a memory test which is failing because the test runner runs out of memory.)
,
Aug 11 2016
This could become a problem if we dump even more information in the trace. I suppose tracing v2 should help address this.
,
Aug 11 2016
cc folks who are working on improving this area of collecting trace from telemetry. I think one fix here could be the presentation of trace in python telemetry is not even a string, but a file pointer. As we stream trace from chrome, we append those trace to some file on disk. Though I worry that we still gonna have the memory error when it's come to time for d8 to run the tracing code on the trace :-( Another dummy question: why top_10_mobile_memory is run on windows? :-/
,
Aug 11 2016
+1 to Ned's last question. Why the heck is this thing even getting run?
,
Aug 12 2016
+rmcilroy, is there a reason for the v8 mobile benchmarks to be running on non-mobile platforms?
,
Aug 12 2016
As discussed on the code review, this was being run on desktop to get some coverage of Ignition on desktop. Going forward we are going to move the collection of these metrics into v8_browse, so this benchmark should disappear soon. In the mean time, it's fine to disable it on desktop.
,
Aug 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cdeb2d5f4785e9ccbaf4b6f0235021b0a436cf2 commit 0cdeb2d5f4785e9ccbaf4b6f0235021b0a436cf2 Author: perezju <perezju@chromium.org> Date: Sat Aug 13 10:17:53 2016 [tools/perf] Enable v8 top_10_mobile benchmarks on mobile only These benchmarks should not be running on non-mobile platforms. BUG= 636790 , 630854 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2232203005 Cr-Commit-Position: refs/heads/master@{#411891} [modify] https://crrev.com/0cdeb2d5f4785e9ccbaf4b6f0235021b0a436cf2/tools/perf/benchmarks/v8.py
,
Aug 15 2016
No longer running on windows |
||||
►
Sign in to add a comment |
||||
Comment 1 by petrcermak@chromium.org
, Aug 11 2016