New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636765 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Aug 2016
Cc:
asvitk...@chromium.org
skare@chromium.org
isherman@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Chrome crashes when the same finch field trial is specified in chrome://flags and in field trial config

Project Member Reported by jkrcal@chromium.org, Aug 11 2016 
The trial variation parameters selected in chrome://flags are registered first. Registering overrides from field trial config happens later and crashes if the same trial is specified.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25e794db58321015633eb287553b8a529eb8e309

commit 25e794db58321015633eb287553b8a529eb8e309
Author: jkrcal <jkrcal@chromium.org>
Date: Fri Aug 12 05:36:18 2016

Resolve conflict in chrome://flags and field trial config.

Chrome crashed when the same finch field trial is specified in
chrome://flags and in field trial config. The trial variation parameters
selected in chrome://flags are registered first. Registering overrides
from field trial config happens later (and may cause a DCHECK failure).

This CL skips field trials from the trial config that have been
registered before (from chrome://flags).

BUG= 636765 

Review-Url: https://codereview.chromium.org/2236293002
Cr-Commit-Position: refs/heads/master@{#411558}

[modify] https://crrev.com/25e794db58321015633eb287553b8a529eb8e309/chrome/common/variations/variations_util.cc

Comment 2 by jkrcal@chromium.org, Aug 12 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment