New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636709 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [MD Settings] Page does not navigate to 'Reset' section after clicking on 'Reset' button from side nav bar.

Reported by rk...@etouch.net, Aug 11 2016 
Chrome Version: 54.0.2826.0 Revision 58bed46055a79ffc0dc4210601d260e3b3e75dbc-refs/heads/master@{#411209}(32/64 bit)
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings then click on side nav bar.
(2) Click on 'Advanced' and then click on 'Reset' button, scroll up page.
(3) Again repeat step 2 and observe

Actual: Page does not navigate to 'Reset' section after clicking on 'Reset' button from side nav bar.

Expected: Page should navigate to 'Reset' section after clicking on 'Reset' button from side nav bar.

This is a regression issue, broken in 'M-54', will soon update the other info:

Comment 1 by rk...@etouch.net, Aug 11 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 54.0.2810.0
Bad Build: 54.0.2811.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/5d555d2d08cab96acb183bd6032a8adcc4ceb3e5..4fd767727f8a4bd4e86d626fce4921972f8180f8?pretty=fuller&n=10

Suspecting: r408466
Actual_Settings.mp4
780 KB View Download
Expected_Settings.mp4
847 KB View Download

Comment 2 by tommycli@chromium.org, Aug 12 2016

Status: Started (was: Assigned)

Comment 3 by tommycli@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/289c535c036c6a3120b884a5f1e41cb89b18cf6e

commit 289c535c036c6a3120b884a5f1e41cb89b18cf6e
Author: tommycli <tommycli@chromium.org>
Date: Fri Aug 12 21:35:54 2016

Settings Router Refactor: Allow no-op navigations.

If the router swallows no-op navigations, repeated navigations from
settings-menu to the same section no longer scrolls the page.

Moreover - repeated navigations to the same anchor link are normally
are normally pushed to history, so coalescing these navigations into a
single history entry might be confusing.

BUG= 636709 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2242863002
Cr-Commit-Position: refs/heads/master@{#411782}

[modify] https://crrev.com/289c535c036c6a3120b884a5f1e41cb89b18cf6e/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/289c535c036c6a3120b884a5f1e41cb89b18cf6e/chrome/browser/resources/settings/settings_main/settings_main.js

Comment 5 by durga.behera@chromium.org, Aug 16 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2830.0
Verified the issue on Windows 10,Mac 10.11.5 and Ubuntu 14.04 using 54.0.2830.0 and its working fine.Please find the attached screen cast for the same.
636709_Aug_16.mp4
604 KB View Download
►

Sign in to add a comment