MacViewsBrowser: Restore pages bubble missing shadow. |
|||
Issue descriptionVersion: 54.0.2819.0 OS: Mac What steps will reproduce the problem? (1) Start a MacViewsBrowser build. (2) Open some tabs in the browser. (3) Press Ctrl+C in the terminal to kill the Chromium app. (4) Again run the app from the terminal. (5) Restore pages bubble should show up and have a shadow. (6) Open a new tab. (7) Move back to the tab with Restore pages bubble. What is the expected output? Restore pages bubble should have a shadow. What do you see instead? Restore pages bubble doesn't have a shadow. (See screenshot). This seems similar to the earlier reported shadow issue in http://crbug.com/588530 , though I can't reproduce it with "Disable Developer Mode extensions" bubble now.
,
Sep 13 2016
,
Sep 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5cbef5ab4cea989839c24925113f5a062a2fb9a commit e5cbef5ab4cea989839c24925113f5a062a2fb9a Author: karandeepb <karandeepb@chromium.org> Date: Thu Sep 15 08:06:07 2016 MacViews: Trigger shadow invalidation when a translucent window is shown. Currently, invalidate_shadow_on_frame_swap_ is not set when a MacViews window is shown. It is only set when the layer is created, changed or the window resized. This causes translucent windows like the "Restore Pages" bubble and Find-In-Page window to not have a shadow, when they are shown after being hidden. This CL modifies BridgedNativeWidget::OnVisibilityChanged() to trigger shadow invalidation while showing translucent windows. This fixes the shadow for the "Restore Pages" bubble and also of the Find-In-Page window on tab switching. A unit test is also added which demonstrates the problem. Note that this does not fix the shadow for the Find-In-Page window when it is displayed initially on pressing Cmd+F. BUG= 636707 , 646734 Review-Url: https://codereview.chromium.org/2336983002 Cr-Commit-Position: refs/heads/master@{#418803} [modify] https://crrev.com/e5cbef5ab4cea989839c24925113f5a062a2fb9a/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/e5cbef5ab4cea989839c24925113f5a062a2fb9a/ui/views/widget/native_widget_mac_unittest.mm
,
Sep 15 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Aug 12 2016Status: Assigned (was: Available)