New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636693 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:After clicking on 'Advanced sync settings' button overlay doesn't appear.

Reported by vku...@etouch.net, Aug 11 2016 
Chrome Version:54.0.2826.0 (Official Build) (64-bit)58bed46055a79ffc0dc4210601d260e3b3e75dbc-refs/heads/master@{#411209} (32/64 Bit)
OS:Windows (7,8,8.1,10) 

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://settings , click on 'sign into chrome' button to login with credentials having passphrase.
(2)Click on 'Advanced sync settings' button such that overlay appears,navigate to chrome://md-settings/syncSetup and enter passphrase.
(3)Switch to chrome://settings tab close the overlay,click on 'Advanced sync settings' button such that it navigate to /md-settings/syncSetup
(4)Now close md-settings/syncSetup tab and click on Advanced sync settings' button, observe.


Actual: After clicking on 'Advanced sync settings' button overlay doesn't appear.

Expected: After clicking on 'Advanced sync settings' button overlay should appear.

This is a regression issue broken in 'M53' and will soon update other info.

Comment 1 by vku...@etouch.net, Aug 11 2016

Labels: hasbisect OS-Linux OS-Mac
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Manual regression range:
Good Build: 53.0.2776.0
Bad Build:  53.0.2777.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/53.0.2776.0..53.0.2777.0?pretty=fuller&n=10000
(Unable to narrow down the range using tool)

Suspecting: 401459 ?
Kindly help to re-assign, if your changes are not cause for this issue.
Actual_Settings.mp4
1.9 MB View Download

Comment 2 by tommycli@chromium.org, Aug 12 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e9a88ea078bd8dbb4f095f8fbc7699716b30f63

commit 0e9a88ea078bd8dbb4f095f8fbc7699716b30f63
Author: tommycli <tommycli@chromium.org>
Date: Mon Aug 15 19:32:51 2016

Settings Sync: Fix CloseUI logic in both Settings and MD Settings.

Previously, the Sync Settings overlay was only properly marked closed if
it was the last-opened instance of Sync Settings.

This patch fixes that.

BUG= 636693 

Review-Url: https://codereview.chromium.org/2244733002
Cr-Commit-Position: refs/heads/master@{#412020}

[modify] https://crrev.com/0e9a88ea078bd8dbb4f095f8fbc7699716b30f63/chrome/browser/ui/webui/options/sync_setup_handler.cc
[modify] https://crrev.com/0e9a88ea078bd8dbb4f095f8fbc7699716b30f63/chrome/browser/ui/webui/settings/people_handler.cc

Comment 4 by tommycli@chromium.org, Aug 16 2016

Status: Fixed (was: Started)
►

Sign in to add a comment