New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636640 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Aug 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Disabled scrollbar at bottom of dialog

Project Member Reported by btolsch@chromium.org, Aug 11 2016 
Version: 54.0.2825.0
OS: Win7, Linux

What steps will reproduce the problem?
(1) Open MR dialog with sinks available.

What is the expected output?
No scrollbar at the bottom of the dialog.

What do you see instead?
A disabled horizontal scrollbar at the bottom of the dialog.

As seen in the attached screenshots, this doesn't happen when there are no sinks.  Also, it's only seen in the sink list (i.e. not the mode picker or route details).  Unconfirmed on Mac and CrOS but it likely affects them too.
Selection_041.png
5.2 KB View Download
Selection_042.png
9.8 KB View Download

Comment 1 by apaci...@chromium.org, Aug 11 2016

Status: apa (was: Untriaged)
May have been me as I recently updated the text width[1]. I made the change on a Mac and there wasn't a scrollbar at the bottom (see screenshot).

[1] https://codereview.chromium.org/2221743002/
Screen Shot 2016-08-10 at 18.25.37.png
14.5 KB View Download

Comment 2 by apaci...@chromium.org, Aug 11 2016

Owner: apaci...@chromium.org
Status: Assigned (was: apa)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533e90adcaf7f718e995130ce936b5c1acbe12de

commit 533e90adcaf7f718e995130ce936b5c1acbe12de
Author: apacible <apacible@chromium.org>
Date: Thu Aug 11 23:51:41 2016

[Media Router WebUI] Remove disabled scrollbar at bottom of dialog.

This was introduced on non-Mac platforms when the width of the sink names was adjusted. Removed the padding as it is unneeded with the other styling; the text is truncated as expected.

Tested manually on Linux and Mac.

BUG= 636640 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2232323003
Cr-Commit-Position: refs/heads/master@{#411453}

[modify] https://crrev.com/533e90adcaf7f718e995130ce936b5c1acbe12de/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css

Comment 4 by apaci...@chromium.org, Aug 11 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment