Click on Omnibar icon does not dismissed Translate Bubble on Mac |
||||
Issue descriptionVersion: M52 and later OS: MacOSX only What steps will reproduce the problem? (1) visit chrome://flags (2) locate "New Translate UX Mac" and set to "Enabled", relaunch (3) visit www.yahoo.co.jp to bring up Translate Bubble. (4) click on the Omnibar Translate icon on top of the Translate Bubble. What is the expected output? Turn off the Translate Bubble What do you see instead? The Bubble flash but stay on. Please use labels and text to provide additional information.
,
Aug 11 2016
We probably should change the code similar to
bool ManagePasswordsDecoration::OnMousePressed(NSRect frame, NSPoint location) {
if (ManagePasswordsBubbleCocoa::instance())
ManagePasswordsBubbleCocoa::instance()->Close();
else
command_updater_->ExecuteCommand(IDC_MANAGE_PASSWORDS_FOR_PAGE);
return true;
}
in
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
The problem is we need to find out is the TranslateBubbleController active or not but it is currently own by BrowserWindwoController and I have not figure out how to hold on to BrowserWindwoController from translate_decoration.mm
,
Aug 11 2016
I guess I need to use NSNotification to send notification from translate_bubble_controller.mm to translate_decoration.mm about the translate bubble status.
,
Aug 19 2016
We've discussed this elsewhere (sorry, no link handy right now), but: All you need to do is make sure that a call to Show() will not re-show the bubble if there still is an existing one. (The focus loss of clicking on the icon will automatically close the bubble, but the variable holding the instance will not be reset until after Show is called again)
,
Aug 23 2016
I propose two fixes: 1. https://codereview.chromium.org/2270913002/ (I think this is the right fix) Looks like groby's earlier attempt to fix crash in bug/609446 cause this side effect. 2. https://codereview.chromium.org/2262913002/ (Please ignore this. This was my early hacky attempt)
,
Apr 17 2017
Won't be launching the new UI on Mac
,
Apr 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ftang@chromium.org
, Aug 11 2016