Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. |
||||||
Issue descriptionEach time I type or delete a character from the omnibox, UpdatePopupApperance is called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance leaks an NSViewController*, as well as all omnibox results. This should be merged to M-53, once the fix has landed in Canary and is stable.
,
Aug 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b87e1820a06ac5dd1d9881be5342286fac920e43 commit b87e1820a06ac5dd1d9881be5342286fac920e43 Author: erikchen <erikchen@chromium.org> Date: Fri Aug 12 14:01:28 2016 Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. Each time I type or delete a character from the omnibox, UpdatePopupApperance is called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance was leaking an NSViewController*, as well as all omnibox results. BUG= 636632 Review-Url: https://codereview.chromium.org/2233123003 Cr-Commit-Position: refs/heads/master@{#411637} [modify] https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h [modify] https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm [modify] https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h [modify] https://crrev.com/b87e1820a06ac5dd1d9881be5342286fac920e43/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
,
Aug 12 2016
,
Aug 12 2016
,
Aug 13 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 14 2016
Please merge your change by Monday (08/15) 5:00 PM PT so we can take it in for next week Beta release. Thank you.
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e53ed2c594fff414ec56f1ae97bfbd297f1d352 commit 7e53ed2c594fff414ec56f1ae97bfbd297f1d352 Author: erikchen <erikchen@chromium.org> Date: Mon Aug 15 22:22:22 2016 [Merge to 2785] Fix many memory leaks in chrome/browser/ui/cocoa/omnibox. > Each time I type or delete a character from the omnibox, UpdatePopupApperance is > called at least 3 times. Each call to OmniboxPopupViewMac::UpdatePopupApperance > was leaking an NSViewController*, as well as all omnibox results. > > BUG= 636632 > > Review-Url: https://codereview.chromium.org/2233123003 > Cr-Commit-Position: refs/heads/master@{#411637} > (cherry picked from commit b87e1820a06ac5dd1d9881be5342286fac920e43) Review URL: https://codereview.chromium.org/2252523002 . Cr-Commit-Position: refs/branch-heads/2785@{#611} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/7e53ed2c594fff414ec56f1ae97bfbd297f1d352/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h [modify] https://crrev.com/7e53ed2c594fff414ec56f1ae97bfbd297f1d352/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm [modify] https://crrev.com/7e53ed2c594fff414ec56f1ae97bfbd297f1d352/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h [modify] https://crrev.com/7e53ed2c594fff414ec56f1ae97bfbd297f1d352/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
,
Aug 19 2016
@erikchen: Hey, are there any manual steps for TE to verify here ? If so, I request you to provide the same to verify the issue. Appreciate your help. Thank you!
,
Aug 19 2016
It's likely possible to use either Instruments or chrome://tracing to verify this, but there is some complexity involved. If TEs are in general interested in the topic of looking into memory leaks, I could probably give a talk about it. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rnimmagadda@chromium.org
, Aug 12 2016