Chrome OS deployment: deploy_chrome.py and chromeos-chrome ebuild file need cleanup |
|||||||||
Issue descriptionThis is a tracking issue for a few other related bugs. We need to do the following cleanup related to chrome deployment: * In chromite: deploy_chrome.py relies on a set of paths defined in chrome_util.py. ** The logic is dependent upon GYP based environment variables which will soon be deprecated. ** At least some of these are out of date, they need to be audited. * In chromeos-chrome-9999.ebuild performs some additional copying, much of it obsolete or not always applicable, resulting in a large number of 'cannot stat' and 'rsync failed' messages. ** We should move as much of this as possible into deploy_chrome.py.
,
Sep 21 2016
,
Sep 22 2016
Clearing the Proj-GN-Migration label since it didn't block the GN migration (I'm trying to figure out what, if any GYP/GN-related tasks might be left).
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5 commit 368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 23 20:05:21 2016 Add --gn-args parameter to deploy_chrome for future use by the chromeos-chrome ebuild. This also outputs GYP_DEFINES and GN_ARGS taken from the environment as info logging for debuging builders. BUG= chromium:636622 TEST=./cbuildbot/run_tests scripts/deploy_chrome_unittest Change-Id: Iec612340113baf81c01da702d1c774fc390c6a83 Reviewed-on: https://chromium-review.googlesource.com/388900 Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5/scripts/deploy_chrome.py
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5 commit 368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 23 20:05:21 2016 Add --gn-args parameter to deploy_chrome for future use by the chromeos-chrome ebuild. This also outputs GYP_DEFINES and GN_ARGS taken from the environment as info logging for debuging builders. BUG= chromium:636622 TEST=./cbuildbot/run_tests scripts/deploy_chrome_unittest Change-Id: Iec612340113baf81c01da702d1c774fc390c6a83 Reviewed-on: https://chromium-review.googlesource.com/388900 Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5/scripts/deploy_chrome.py
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5 commit 368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Sep 23 20:05:21 2016 Add --gn-args parameter to deploy_chrome for future use by the chromeos-chrome ebuild. This also outputs GYP_DEFINES and GN_ARGS taken from the environment as info logging for debuging builders. BUG= chromium:636622 TEST=./cbuildbot/run_tests scripts/deploy_chrome_unittest Change-Id: Iec612340113baf81c01da702d1c774fc390c6a83 Reviewed-on: https://chromium-review.googlesource.com/388900 Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/368c3e5db9c91424852aa37d8ef51f7a6d4ef2f5/scripts/deploy_chrome.py
,
Dec 16 2016
The essential cleanup here has been done, and no more gyp references remain. Closing this.
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by steve...@chromium.org
, Aug 11 2016