New issue
Advanced search Search tips

Issue 636604 link

Starred by 1 user
Status: Fixed
Owner:
tguilbert@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 619729



Sign in to add a comment

Pass first party URL from WMPI to MediaPlayerRenderer

Project Member Reported by tguilbert@chromium.org, Aug 10 2016 
At the moment, MPR uses an empty GURL instead of a first party URL when initializing. This means that some media will not be available for playback, if it requires cookies/authentication.

This bug tracks the work for plumbing the first party token from WMPI to the MediaPlayerRenderer.

Comment 1 by tguilbert@chromium.org, Oct 20 2016

Description: Show this description

Comment 2 by tguilbert@chromium.org, Oct 20 2016

Summary: Pass first party URL from WMPI to MediaPlayerRenderer (was: Pass first party cookies from WMPI to MediaPlayerRenderer)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9881bc24551338fe9644f02265e7269e73a07765

commit 9881bc24551338fe9644f02265e7269e73a07765
Author: tguilbert <tguilbert@chromium.org>
Date: Thu Oct 27 03:13:41 2016

Plumb firstPartyForCookies() to MediaPlayerBridge

Currently, the MediaPlayerRenderer does not allow authenticated
playback.

This change adds the necessary plumbing to send the first party URL
from blink::WebLocalFrame to the MediaPlayerBridge, in order to access
(or to be denied access to) the first party cookies.

Also opened 659826 which might necessite further investigation.

BUG= 636604 
TEST=updated UTs for MediaUrlDemuxer

Review-Url: https://codereview.chromium.org/2434413002
Cr-Commit-Position: refs/heads/master@{#427924}

[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/content/browser/media/android/media_player_renderer.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/BUILD.gn
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/demuxer_stream_provider.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/demuxer_stream_provider.h
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/media_url_demuxer.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/media_url_demuxer.h
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/media_url_demuxer_unittest.cc
[add] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/media_url_params.h
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/base/pipeline_impl.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/mojo/clients/mojo_renderer.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/mojo/interfaces/renderer.mojom
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/mojo/services/media_mojo_unittest.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/mojo/services/mojo_renderer_service.cc
[modify] https://crrev.com/9881bc24551338fe9644f02265e7269e73a07765/media/mojo/services/mojo_renderer_service.h

Comment 4 by tguilbert@chromium.org, Oct 27 2016

Status: Fixed (was: Available)
►

Sign in to add a comment