New issue
Advanced search Search tips

Issue 636588 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 619729



Sign in to add a comment

Support RegisterMediaUrlInterceptor in MediaPlayerRenderer

Project Member Reported by tguilbert@chromium.org, Aug 10 2016

Issue description

WMPA used BrowserMediaPlayerManager to register a custom UrlInterceptor for use in webview.

We need to offer the equivalent mechanism before deleting WMPA and switching to the MediaPlayerRenderer (see  crbug.com/619729 ).

 
Cc: -tguilbert@chromium.org
Owner: tguilbert@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/251a73761e1da752b87eeb5ea7e22a5b1f164a85

commit 251a73761e1da752b87eeb5ea7e22a5b1f164a85
Author: tguilbert <tguilbert@chromium.org>
Date: Tue Nov 15 02:13:38 2016

Add MediaUrlInterceptor support to MediaPlayerRenderer

This change allows webview apps to register a custom
MediaUrlInterceptor. This change simply copies the code in
BrowserMediaPlayerManager.

BUG= 636588 

Review-Url: https://codereview.chromium.org/2463533002
Cr-Commit-Position: refs/heads/master@{#432060}

[modify] https://crrev.com/251a73761e1da752b87eeb5ea7e22a5b1f164a85/content/browser/media/android/media_player_renderer.cc
[modify] https://crrev.com/251a73761e1da752b87eeb5ea7e22a5b1f164a85/content/browser/media/android/media_player_renderer.h
[modify] https://crrev.com/251a73761e1da752b87eeb5ea7e22a5b1f164a85/content/public/browser/android/browser_media_player_manager_register.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20038e2480c5e8fd98615cc63a48db56b6da3eab

commit 20038e2480c5e8fd98615cc63a48db56b6da3eab
Author: tguilbert <tguilbert@chromium.org>
Date: Wed Nov 16 01:22:35 2016

Register MediaUrlInterceptor with MediaPlayerRenderer

A recent review added RegisterMediaUrlInterceptor() to the
MediaPlayerRenderer.

The function was never used, because conditionally enabling it by using
base::FeatureList from AwMainDelegate::BasicStartupComplete() prevented
certain Java tests from running.

Using base::FeatureList is uncessary, because we can register the
MediaUrlInterceptor both in the BrowserMediaPlayerManager and the
MediaPlayerRenderer without any problems. This change adds the extra
registration

BUG= 636588 

Review-Url: https://codereview.chromium.org/2503793003
Cr-Commit-Position: refs/heads/master@{#432334}

[modify] https://crrev.com/20038e2480c5e8fd98615cc63a48db56b6da3eab/content/public/browser/android/browser_media_player_manager_register.cc

Blocking: 619729
Adding reference to main MediaPlayerRender tracking bug.
Status: Fixed (was: Started)

Sign in to add a comment