New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 636541 link

Starred by 1 user
Status: Fixed
Owner:
wfh@chromium.org
Closed: Aug 2016
Cc:
█ amineer@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

ooms on windows do not increment UMA crash counts

Project Member Reported by wfh@chromium.org, Aug 10 2016 
when a new TerminationStatus for OOM was added on Windows in https://codereview.chromium.org/2172013002 (first in 54.0.2809.0) for OOM the code in StabilityMetricsHelper::LogRendererCrash was not correctly updated to cater for this new termination status.

As a result, OOM renderer process terminations are not counted in stability data as renderer_crash_count or extension_renderer_crash_count, nor is the correct CrashExitCodes.* histogram bucket being incremented.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1633bec645f94fa0681eeccf7704491b336489a8

commit 1633bec645f94fa0681eeccf7704491b336489a8
Author: wfh <wfh@chromium.org>
Date: Fri Aug 12 02:07:24 2016

Correctly increment crashed renderer process stability counts on OOM.

Change the code to use a switch statement to detect changes to enum in future. Add tests.

BUG= 636541 
TEST=components_unittests

Review-Url: https://codereview.chromium.org/2233303002
Cr-Commit-Position: refs/heads/master@{#411519}

[modify] https://crrev.com/1633bec645f94fa0681eeccf7704491b336489a8/components/metrics/stability_metrics_helper.cc
[modify] https://crrev.com/1633bec645f94fa0681eeccf7704491b336489a8/components/metrics/stability_metrics_helper_unittest.cc

Comment 2 by wfh@chromium.org, Aug 15 2016

Status: Fixed (was: Started)
Verified this is working by going to go/oom-crashes and the graph is working again since 54.0.2828.0
►

Sign in to add a comment