For every perf tryjob we run, src/tools/run-perf-test.cfg file is modified with test params and uploaded along with the patch to be tested. Instead use git cl try command --properties option to set test arguments.
Is this blocking bug 636505?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/ffbc3a07de505fb7e47bc274dd1eeeda31092feb commit ffbc3a07de505fb7e47bc274dd1eeeda31092feb Author: prasadv <prasadv@chromium.org> Date: Fri Aug 12 22:13:59 2016 Add support to Perf tryjobs to read test attributes from buildbot properties. BUG= 636507 Review-Url: https://codereview.chromium.org/2237293005 [modify] https://crrev.com/ffbc3a07de505fb7e47bc274dd1eeeda31092feb/scripts/slave/recipe_modules/auto_bisect/api.py [modify] https://crrev.com/ffbc3a07de505fb7e47bc274dd1eeeda31092feb/scripts/slave/recipe_modules/perf_try/api.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/f91e567f2dd48210d6eb1f7056beba0680cd7b68 commit f91e567f2dd48210d6eb1f7056beba0680cd7b68 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Aug 12 22:21:56 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/004cf1209f4147996ef78cc3249ed58ba6ea7d54 commit 004cf1209f4147996ef78cc3249ed58ba6ea7d54 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Aug 12 22:36:56 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/ffbc3a07de505fb7e47bc274dd1eeeda31092feb Add support to Perf tryjobs to read test attributes from buildbot properties. (prasadv@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 636507 Recipe-Tryjob-Bypass-Reason: Autoroller Review-Url: https://codereview.chromium.org/2240833004 [modify] https://crrev.com/004cf1209f4147996ef78cc3249ed58ba6ea7d54/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/384a89eeae9f342e3d912ed9d45d3c92e417ef44 commit 384a89eeae9f342e3d912ed9d45d3c92e417ef44 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Aug 19 11:03:06 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/a93ede2801326ddd7ce4574083872e5e54550c05 V8: Make sure infra failures fail overall build (machenbach@chromium.org) https://crrev.com/b83c98d76351019efcf66ed6b8c613aa5a84e815 Drop unwanted dependencies on chromium_tests recipe module (phajdan.jr@chromium.org) https://crrev.com/2242ecf4294749afda3518e9cdf533b00e8dd007 Delete cipd recipe module in build; it's been moved to depot_tools (phajdan.jr@chromium.org) https://crrev.com/f1b32044c0c3d1a6f8e1c58fa05534ef346ea7c2 Do not assume that perf tests always have end_time (perezju@chromium.org) https://crrev.com/dea2e51ee8291d1a5ef282e3aed6f7478a9d8308 Add new Cronet bots to gatekeeper.json (xunjieli@chromium.org) https://crrev.com/43aa621d3e16b8cbd84a615e2f8da24e6eaf5595 Reland of moving old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2214303003/ ) (martiniss@chromium.org) https://crrev.com/67265eee096098edc7ab09bd537bdef18ac2d5a5 Revert of moving old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2240303002/ ) (martiniss@chromium.org) https://crrev.com/c9c68ee6bcf16f9b5e3b0a9a34e4720ebf9d0126 Add logcats link in builbot page for android swarming tasks (nicholaslin@google.com) https://crrev.com/a3823b7f9124119e09b8669c42d9f22d9ed3d660 Kill simctl along with simulator instances before starting iOS tests (smut@google.com) https://crrev.com/ffbc3a07de505fb7e47bc274dd1eeeda31092feb Add support to Perf tryjobs to read test attributes from buildbot properties. (prasadv@chromium.org) https://crrev.com/d21d20dbc8088adc31faee64e72eea0bdcbf03fa Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/5889cad061cfbd10c0c753c5794d40ad6ea33df0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/8d6920e1efb3a9e23856fec36faa41df85c263d7 Update path to entry points config file (abarth@chromium.org) https://crrev.com/1aa280064119546863fd9bfd25d06cb0b2743329 Add command to run earlgrey tests upstream. (huangml@google.com) https://crrev.com/5ab8d37cf2275de48cf08075832caed435b518ca Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/8f8e75bf00b67db48cf9c83191b7ec0dc8932570 Revert of Require internal recipe tryjob (patchset #1 id:1 of https://codereview.chromium.org/2187073004/ ) (martiniss@chromium.org) https://crrev.com/00c6a328904a2b9fc3fa298d0d11e8992b90ff1a Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/0c561b329b668ec0e2d56a712005606917716ec3 Cleanup old debugging code. (tandrii@chromium.org) recipe_engine: https://crrev.com/9581df50945817b006054cc9a4415a38803885a7 Revert of Require internal recipe tryjob (patchset #1 id:1 of https://codereview.chromium.org/2187493005/ ) (martiniss@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:448050 , 635616 , 636507 ,629679,637429, 537417 ,584079, 628801 , 635421 ,637076, 593999 ,632309 Recipe-Tryjob-Bypass-Reason: Autoroller Review-Url: https://codereview.chromium.org/2260143002 Cr-Commit-Position: refs/heads/master@{#413105} [modify] https://crrev.com/384a89eeae9f342e3d912ed9d45d3c92e417ef44/infra/config/recipes.cfg
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62facebbb3a84eb18d7964207b70be380320ddbd commit 62facebbb3a84eb18d7964207b70be380320ddbd Author: prasadv <prasadv@chromium.org> Date: Wed Aug 31 23:25:43 2016 Use git cl try --properties option to send test arguments instead of run-perf-test.cfg BUG= 636507 Review-Url: https://codereview.chromium.org/2287993004 Cr-Commit-Position: refs/heads/master@{#415801} [modify] https://crrev.com/62facebbb3a84eb18d7964207b70be380320ddbd/tools/perf/core/trybot_command.py [modify] https://crrev.com/62facebbb3a84eb18d7964207b70be380320ddbd/tools/perf/core/trybot_command_unittest.py
Comment 1 by sullivan@chromium.org
, Aug 10 2016